From: Cyrill Gorcunov <gorcunov@gmail.com>
To: bfields@fieldses.org, neilb@suse.de, ibm-acpi@hmh.eng.br,
len.brown@intel.com, kkeil@suse.de
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Cyrill Gorcunov <gorcunov@gmail.com>
Subject: [patch 2/3] CAPIFS: fix memory leak on remount
Date: Wed, 16 Apr 2008 21:44:23 +0400 [thread overview]
Message-ID: <48063bc9.2234440a.747d.09eb@mx.google.com> (raw)
In-Reply-To: <20080416174421.442716301@gmail.com>
[-- Attachment #1: capi-memory-leak --]
[-- Type: text/plain, Size: 695 bytes --]
capifs_remount may reach 'return' statement
without freeing of memory allocated by kstrdup call
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
Index: linux-2.6.git/drivers/isdn/capi/capifs.c
===================================================================
--- linux-2.6.git.orig/drivers/isdn/capi/capifs.c 2008-04-16 20:14:46.000000000 +0400
+++ linux-2.6.git/drivers/isdn/capi/capifs.c 2008-04-16 20:16:58.000000000 +0400
@@ -69,6 +69,7 @@ static int capifs_remount(struct super_b
} else if (sscanf(this_char, "mode=%o%c", &n, &dummy) == 1)
mode = n & ~S_IFMT;
else {
+ kfree(new_opt);
printk("capifs: called with bogus options\n");
return -EINVAL;
}
--
next prev parent reply other threads:[~2008-04-16 17:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080416174421.442716301@gmail.com>
2008-04-16 17:44 ` [patch 1/3] NFS: fix potential NULL pointer dereference Cyrill Gorcunov
2008-04-16 18:11 ` Trond Myklebust
2008-04-16 18:13 ` Cyrill Gorcunov
2008-04-16 18:55 ` Trond Myklebust
2008-04-16 20:19 ` Cyrill Gorcunov
2008-04-16 20:40 ` Trond Myklebust
2008-04-17 4:25 ` Cyrill Gorcunov
2008-04-17 7:25 ` Cyrill Gorcunov
2008-04-16 20:24 ` Cyrill Gorcunov
2008-04-16 17:44 ` Cyrill Gorcunov [this message]
2008-04-16 17:44 ` [patch 3/3] ThinkPad ACPI: fix possible " Cyrill Gorcunov
2008-04-16 20:52 ` Henrique de Moraes Holschuh
2008-04-18 12:41 ` Pavel Machek
2008-04-18 12:55 ` Cyrill Gorcunov
2008-04-18 13:07 ` Cyrill Gorcunov
2008-04-19 4:10 ` Henrique de Moraes Holschuh
2008-04-18 13:53 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48063bc9.2234440a.747d.09eb@mx.google.com \
--to=gorcunov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=ibm-acpi@hmh.eng.br \
--cc=kkeil@suse.de \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome