Re: 2.6.14.3 and page allocation failures..

[Jesse Brandeburg <jesse.brandeburg@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

On 1/23/06, Sai Bathina <sai.bathina@gmail.com> wrote:
> Hi,
>      I am seeing page allocation errors and I have a snapshot of the
> /var/log/messages.
>
> My Hardware configs are
> Dell 750, using e1000 driver(e1000-6.2.15)

there is a leak in the 6.2.15 driver (this leak was not in the code
submitted to the kernel)

you can either use 6.3.9 or you can fix this by applying this attached
patch (or something similar)

Jesse

[-- Attachment #2: allocate_rx_buffer_change from 6.2.15-to-6.3.9.patch --]
[-- Type: application/octet-stream, Size: 873 bytes --]

--- linux-2.6.5-7.244/drivers/net/e1000/e1000_main.c.orgi	2006-01-12 22:03:43.147940808 -0600
+++ linux-2.6.5-7.244/drivers/net/e1000/e1000_main.c	2006-01-12 22:03:38.000000000 -0600
@@ -441,9 +441,14 @@ e1000_up(struct e1000_adapter *adapter)
 	e1000_configure_tx(adapter);
 	e1000_setup_rctl(adapter);
 	e1000_configure_rx(adapter);
-	for (i = 0; i < adapter->num_queues; i++)
-		adapter->alloc_rx_buf(adapter, &adapter->rx_ring[i],
-					adapter->rx_ring[i].count);
+	/* call E1000_DESC_UNUSED which always leaves
+	 * at least 1 descriptor unused to make sure
+	 * next_to_use != next_to_clean */
+	for (i = 0; i < adapter->num_rx_queues; i++) {
+		struct e1000_rx_ring *ring = &adapter->rx_ring[i];
+		adapter->alloc_rx_buf(adapter, ring,
+		                      E1000_DESC_UNUSED(ring));
+	}
 
 #ifdef CONFIG_PCI_MSI
 	if(adapter->hw.mac_type > e1000_82547_rev_2) {