From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S1751212AbWFBGrx@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751212AbWFBGrx (ORCPT <rfc822;willy@w.ods.org>);
	Fri, 2 Jun 2006 02:47:53 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751214AbWFBGrx
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 2 Jun 2006 02:47:53 -0400
Received: from nf-out-0910.google.com ([64.233.182.189]:11496 "EHLO
	nf-out-0910.google.com") by vger.kernel.org with ESMTP
	id S1751212AbWFBGrw (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 2 Jun 2006 02:47:52 -0400
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=KjvvQidFFJ+F9vCBnMMtACWaZ5lviDcr/Kzi2rB1rT0Q8j0uaOFExVTD/WrmHY7k6okBUBV+C0Zp2tJn6wHIZfycBXrjOyqBGUTCT3VjwRuCJZ3pUBrD9nduheK10hHG9yHNZG4J2YX3LVTFPVEZN91n3GVFuTbT9DxDFIspnIs=
Message-ID: <4807377b0606012347o7e1ca193lda3c3654dbda3323@mail.gmail.com>
Date: Thu, 1 Jun 2006 23:47:50 -0700
From: "Jesse Brandeburg" <jesse.brandeburg@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Subject: Re: [patch, -rc5-mm1] lock validator: special locking: net/ipv4/igmp.c #2
Cc: "Linux-Kernel," <linux-kernel@vger.kernel.org>,
       "Andrew Morton" <akpm@osdl.org>,
       "Arjan van de Ven" <arjan@infradead.org>,
       "NetDEV list" <netdev@vger.kernel.org>
In-Reply-To: <20060601063537.GA19931@elte.hu>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <4807377b0605311704g44fe10f1oc54315276890071@mail.gmail.com>
	 <20060601063537.GA19931@elte.hu>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/31/06, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Jesse Brandeburg <jesse.brandeburg@gmail.com> wrote:
>
> > well, when running e1000 through some code paths on FC4 +
> > 2.6.17-rc5-mm1 + ingo's latest rollup patch, with this lockdep debug
> > option enabled I got this:
> >
> > e1000: eth1: e1000_watchdog_task: NIC Link is Up 1000 Mbps Full Duplex
> >
> > ======================================
> > [ BUG: bad unlock ordering detected! ]
> > --------------------------------------
> > mDNSResponder/2361 is trying to release lock (&in_dev->mc_list_lock) at:
> > [<ffffffff81233f5a>] ip_mc_add_src+0x85/0x1f8
>
> ok, could you try the patch below? (i also updated the rollup with this
> fix)
>
>         Ingo
>
> ---------------------
> Subject: lock validator: special locking: net/ipv4/igmp.c #2
> From: Ingo Molnar <mingo@elte.hu>
>
> another case of non-nested unlocking igmp.c.
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
>  net/ipv4/igmp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux/net/ipv4/igmp.c
> ===================================================================
> --- linux.orig/net/ipv4/igmp.c
> +++ linux/net/ipv4/igmp.c
> @@ -1646,7 +1646,7 @@ static int ip_mc_add_src(struct in_devic
>                 return -ESRCH;
>         }
>         spin_lock_bh(&pmc->lock);
> -       read_unlock(&in_dev->mc_list_lock);
> +       read_unlock_non_nested(&in_dev->mc_list_lock);
>
>  #ifdef CONFIG_IP_MULTICAST
>         sf_markstate(pmc);
>

yep, this fixes it.