From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Jarod Wilson <jwilson@redhat.com>
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH update] firewire: fw-ohci: work around generation bug in TI controllers (fix AV/C and more)
Date: Fri, 18 Apr 2008 00:47:16 +0200 [thread overview]
Message-ID: <4807D374.8090608@s5r6.in-berlin.de> (raw)
In-Reply-To: <200804141330.22131.jwilson@redhat.com>
Jarod Wilson wrote:
> On Saturday 12 April 2008 04:31:25 pm Stefan Richter wrote:
>> + ohci->bus_reset_packet_quirk = dev->vendor == PCI_VENDOR_ID_TI;
>> +
>
> I have a few cards with PCI_VENDOR_ID_CREATIVE with a TI TSB41AB2 chip on 'em
> (SoundBlaster Audigy w/FireWire port). I've not had any issues on any of the
> cards I've got, but do we want to add them to the work-around list just to be
> safe?
No, we don't need to. TSB41AB2 is only a PHY, not a link layer
controller. While the PHYs (the combination of PHYs which are present
on the bus) influence the conditions under which the bug can happen, the
cause for the bug is in the link layer controller alone.
So unless Creative used a TI design in their link layer controller or
otherwise managed to implement this same quirk as TI (Agere, NEC, and
VIA didn't according to my tests so far), the presence of TSB41AB2 on a
card does not make it necessary to activate the quirk workaround.
--
Stefan Richter
-=====-==--- -=-- =--=-
http://arcgraph.de/sr/
next prev parent reply other threads:[~2008-04-17 22:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-12 19:26 [PATCH] " Stefan Richter
2008-04-12 20:31 ` [PATCH update] " Stefan Richter
2008-04-14 17:30 ` Jarod Wilson
2008-04-16 10:21 ` Stefan Richter
2008-04-17 22:47 ` Stefan Richter [this message]
2008-04-18 2:51 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4807D374.8090608@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=jwilson@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®