From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751834AbbIOUaR (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Sep 2015 16:30:17 -0400
Received: from mout.kundenserver.de ([212.227.17.10]:50823 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751272AbbIOUaP (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Sep 2015 16:30:15 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: y2038@lists.linaro.org
Cc: Andreas Oberritter <obi@saftware.de>, linux-media@vger.kernel.org,
        linux-api@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Subject: Re: [Y2038] [PATCH 1/7] [media] dvb: use ktime_t for internal timeout
Date: Tue, 15 Sep 2015 22:30 +0200
Message-ID: <48082122.rhhMXK7OaH@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <55F85B97.8000700@saftware.de>
References: <1442332148-488079-1-git-send-email-arnd@arndb.de> <1442332148-488079-2-git-send-email-arnd@arndb.de> <55F85B97.8000700@saftware.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:8m9zaS0mjKejgepLxuvlwWclNLWT2ue1QBWRSIBTjooY02mRpkD
 wWNBlom/Gn/6ksJB7x/MKalzNOo9XS/k9ZMlLqWfnTmrnH1qYg2r2ipfKYg8umavfPzpMtP
 6ZkGaiRKbaE5oaZbL5yU60ZMIlA+DNKjiTiDueGj7O5Q7gXofTxFwpgPF+zrfEiI6VbeSZz
 dCQd2yaQ9oG+EPDUKLhrQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:ehpJThG1S48=:M/8kQntCe5pTsg3UtvxS8r
 7mGGklBmLyGQG7Tv+kU/D+HhCdj153/qWhnh1U/smrPig/k6/wAYweX4gTGuerLgIQBWhRY+2
 qBwWwvrnpv5VDZQ7T/6vJpGlhLNDqGZF6Lu2/gYlk5sOb/0EtlaDmcI821thiyPbe4OGJy97w
 E6w+Vi7QvnYTn1MVbAQX2Z09DNuGlpiBDFr4mzfdaPoolZR921C0KqENHCqYR4YwTBt9+AyBM
 BHU6xjyUkDA4Dc+vt9dz3Ic4Mz22rxZh1mXfPgxlELT4HMWX8dN28JLDek9/w+wk2i8T04p5E
 Wh2VwLMvJe8sMry5b1kMOfvuG6SxMInoMXPbll0oOJy4YcfIreFDyBM5DD32QDW+YF3qXDujJ
 9ZEmkAV5xZbgLh5jZcCqiMK12aEEFvAGVRiX4mlr/svbkr4R67ptxNhbovTsixstmPfAUD2Rt
 A2d2iNj9onyiSS5rLPi30H11u4SZfrpIIIpfOp6MpVVofjQzVUNoTVaNTr1y6UJG9cCWV1lbB
 CKZU65WK07XdnYZiNSe5n1JydZM+pzvQxQCZgsnOdBIDiVZUDX6ZgqSTPyDtNT0yVsy/TlnSu
 ZsCvcRDH6J1mH9kY+qT7yYSifXkDM8uaAOFmVeHAjXeepnsaY8+rcYPbP07fvb30FsLVKw62H
 I7dTQDr5CL3DZ73gbMvrz98ldGrDinDQ32mOngw8s5Zs/g6225PRHbE2D93iYGLw5tqxaEvvn
 a6LXvlpAMFG9QBFo
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 15 September 2015 19:55:35 Andreas Oberritter wrote:

> >  		/* show speed every SPEED_PKTS_INTERVAL packets */
> >  		if (!(demux->speed_pkts_cnt % SPEED_PKTS_INTERVAL)) {
> > -			cur_time = current_kernel_time();
> > +			cur_time = ktime_get();
> >  
> > -			if (demux->speed_last_time.tv_sec != 0 &&
> > -					demux->speed_last_time.tv_nsec != 0) {
> > -				delta_time = timespec_sub(cur_time,
> > -						demux->speed_last_time);
> > +			if (ktime_to_ns(demux->speed_last_time) == 0) {
> 
> if ktime_to_ns does what I think it does, then you should invert the logic.

Thanks for taking a critical look here, you are absolutely right, and I've
now fixed it.

	Arnd