mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Taniya Das <tdas@codeaurora.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: clock: qcom,gcc-sm8250: add missing bi_tcxo_ao clock
Date: Sat, 8 Apr 2023 16:00:08 +0200	[thread overview]
Message-ID: <4808aa04-67f6-82d9-0d77-337b30aeb442@linaro.org> (raw)
In-Reply-To: <20230408134820.76050-1-krzysztof.kozlowski@linaro.org>



On 8.04.2023 15:48, Krzysztof Kozlowski wrote:
> Without actual explanation commit 76bd127e6ca5 ("arm64: dts: qcom:
> sm8250: add bi_tcxo_ao to gcc clocks") added bi_tcxo_ao clock input to
> the GCC clock controller, so update the bindings hoping this is really
> needed.  This fixes warnings like:
The initial commit 3e5770921a88
("clk: qcom: gcc: Add global clock controller driver for SM8250")
already consumed it on the .c side, so the bindings were wrong..

> 
>   sm8250-xiaomi-elish-csot.dtb: clock-controller@100000: clock-names: ['bi_tcxo', 'bi_tcxo_ao', 'sleep_clk'] is too long
> 
> Fixes: 76bd127e6ca5 ("arm64: dts: qcom: sm8250: add bi_tcxo_ao to gcc clocks")
s/this/98394efb48f5 ("dt-bindings: clock: Add SM8250 GCC clock bindings")

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml
> index b752542ee20c..ead6665b9a45 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml
> @@ -23,11 +23,13 @@ properties:
>    clocks:
>      items:
>        - description: Board XO source
> +      - description: Board active XO source
>        - description: Sleep clock source
>  
>    clock-names:
>      items:
>        - const: bi_tcxo
> +      - const: bi_tcxo_ao
>        - const: sleep_clk
>  
>  required:
> @@ -47,8 +49,9 @@ examples:
>        compatible = "qcom,gcc-sm8250";
>        reg = <0x00100000 0x1f0000>;
>        clocks = <&rpmhcc RPMH_CXO_CLK>,
> +               <&rpmhcc RPMH_CXO_CLK_A>,
>                 <&sleep_clk>;
> -      clock-names = "bi_tcxo", "sleep_clk";
> +      clock-names = "bi_tcxo", "bi_tcxo_ao", "sleep_clk";
>        #clock-cells = <1>;
>        #reset-cells = <1>;
>        #power-domain-cells = <1>;

  parent reply	other threads:[~2023-04-08 14:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-08 13:48 Krzysztof Kozlowski
2023-04-08 13:48 ` [PATCH 2/3] dt-bindings: clock: qcom,gcc-sc7180: document CX power domain Krzysztof Kozlowski
2023-04-08 14:03   ` Konrad Dybcio
2023-04-11  4:56     ` Rajendra Nayak
2023-04-11 11:27       ` Konrad Dybcio
2023-04-11 13:31         ` Rajendra Nayak
2023-04-11 13:45           ` Konrad Dybcio
2023-04-12  5:42             ` Rajendra Nayak
2023-04-12 10:34               ` Konrad Dybcio
2023-04-12 15:16   ` Rob Herring
2023-04-08 13:48 ` [PATCH 3/3] dt-bindings: clock: qcom,gcc-sc7280: " Krzysztof Kozlowski
2023-04-08 14:04   ` Konrad Dybcio
2023-04-12 15:17   ` Rob Herring
2023-04-08 14:00 ` Konrad Dybcio [this message]
2023-04-10 19:33 ` [PATCH 1/3] dt-bindings: clock: qcom,gcc-sm8250: add missing bi_tcxo_ao clock Stephen Boyd
2023-04-12 15:15 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4808aa04-67f6-82d9-0d77-337b30aeb442@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tdas@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®