From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753182AbdCIIaD (ORCPT ); Thu, 9 Mar 2017 03:30:03 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:24677 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752985AbdCII36 (ORCPT ); Thu, 9 Mar 2017 03:29:58 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfec7f5-f79d06d000004445-f7-58c11277ab84 Subject: Re: linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681: suspicious mask ? To: Inki Dae , David Binderman , "jy0922.shim@samsung.com" , "sw0312.kim@samsung.com" , "kyungmin.park@samsung.com" , "airlied@linux.ie" , "kgene@kernel.org" , "krzk@kernel.org" , "javier@osg.samsung.com" , "dri-devel@lists.freedesktop.org" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Andrzej Hajda Message-id: <4809303a-ab12-6246-63b5-b92e928eae2a@samsung.com> Date: Thu, 09 Mar 2017 09:29:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 In-reply-to: <58C10571.9050107@samsung.com> Content-transfer-encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAKsWRmVeSWpSXmKPExsWy7djPc7rlQgcjDCZs5bboPXeSyeL7wQSL K1/fs1lMuj+BxeLN2zVMFi/uXWSx6H/8mtni/PkN7BZnm96wW2x6fI3V4vKuOWwWM87vY7KY MfklmwOvx+OeM2wem1Z1snls//aA1eN+93Emj81L6j229N9l9+jbsorR4/MmuQCOKC6blNSc zLLUIn27BK6MZze3sxQs5q64+zK3gXEiZxcjJ4eEgInE5NMPWCBsMYkL99azdTFycQgJLGWU +P1rKjOE85lRovHcU2aYjnXb7zBBJJYxSvzZsRsswSsgKPFj8j2wUcwCmhIvvkxigSh6xijx svkWWJGwQIrE7g99YAkRgQOsEjO6HjOBJNiAOv5uvskGMclO4v+lm6wgNouAqsSMQ3/BakQF IiR23OgBq+EU0Ja43dvDCLFNXuLgledAQzmAzrvHLjEZypSV2HQA6mgXoHseMUHYwhKvjm9h h7BlJDo7DoI9IyHQzSjxqf8EO4QzhVHi34cZUN3WEoePX2SF2MUnMWnbdGaIBbwSHW1CECUe En1310CVO0qcaO6Cev4io8TcT9cZJzDKzUIKpFlIgTQLyQsLGJlXMYqklhbnpqcWm+oVJ+YW l+al6yXn525iBKaj0/+Of93BuPSY1SFGAQ5GJR7eHQIHIoRYE8uKK3MPMUpwMCuJ8O66BBTi TUmsrEotyo8vKs1JLT7EKM3BoiTOu2fBlXAhgfTEktTs1NSC1CKYLBMHp1QDYxPPgxlFkyas Np3qp8Z//0Qrt5radGObW/0BXn69yZZPSh4eU3PybI5VeBb28bavu0/58v03jRnYSm+uE1io mbMscUXcPGu5d6X/rV+9sdp41mLG1cXpP40P8fJ7cnxd/eLj1I1br6Vq+/Xea0gXPpB4ii0p X+trb/DLunuHfvw631ZRPaEqSYmlOCPRUIu5qDgRABugOepDAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrPIsWRmVeSWpSXmKPExsVy+t/xy7rXhQ5GGLy8aWLRe+4kk8X3gwkW V76+Z7OYdH8Ci8Wbt2uYLF7cu8hi0f/4NbPF+fMb2C3ONr1ht9j0+BqrxeVdc9gsZpzfx2Qx Y/JLNgdej8c9Z9g8Nq3qZPPY/u0Bq8f97uNMHpuX1Hts6b/L7tG3ZRWjx+dNcgEcUW42GamJ KalFCql5yfkpmXnptkqhIW66FkoKeYm5qbZKEbq+IUFKCmWJOaVAnpEBGnBwDnAPVtK3S3DL eHZzO0vBYu6Kuy9zGxgncnYxcnJICJhIrNt+hwnCFpO4cG89WxcjF4eQwBJGieWnPrGCJHgF BCV+TL7H0sXIwcEsoC4xZUouRM0zRomXT74wg9QICyRJPOp7zgKSEBE4wCqxetdtZoiqy4wS +x9+ZQepYhPQlPi7+SYbxFQ7if+XboJtYBFQlZhx6C/YGaICERLzn64CszkFtCVu9/YwgtjM AvISB688Z5nAyD8LyVGzEI6ahaRqASPzKkaR1NLi3PTcYkO94sTc4tK8dL3k/NxNjMDI3Hbs 5+YdjJc2Bh9iFOBgVOLhFRA+ECHEmlhWXJl7iFGCg1lJhHfXJaAQb0piZVVqUX58UWlOavEh RlOgWycyS4km5wOTRl5JvKGJobmloZGxhYW5kZGSOG/JhyvhQgLpiSWp2ampBalFMH1MHJxS DYyV0+Sjf5n1CTQdklAI4F/4vOeg29nJN+NM+v8fmpQjH1UWuEul4KfCzubX6efSmf+IFV9I +f5++l+nxMzsHdHGZ+srO+p3i6z1n58TtblL5s/SZ+Lnv55v3uutq+p7mr1z0QTXxgPMvyrF GqbpbpRUXSTt18LLeWTezbe3l00tf80kMkM/oFeJpTgj0VCLuag4EQBlJDkc4gIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170309082942eucas1p227982703dbec8f5d1453fd898195a3da X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170306100527epcas1p349cea73e30f7720a65d312808c4b2cc3 X-RootMTR: 20170306100527epcas1p349cea73e30f7720a65d312808c4b2cc3 References: <58C10571.9050107@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09.03.2017 08:34, Inki Dae wrote: > Hello David, > > Thanks for report. > > 2017년 03월 06일 19:05에 David Binderman 이(가) 쓴 글: >> Hello there, >> >> linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681]: (warning) Result of operator '|' is always true if one operand is non-zero. Did you intend to use '&'? >> > Right. this is known issue and below patch fixes this, > http://www.spinics.net/lists/dri-devel/msg132589.html > > This patch will go to -fixes. > >> Source code is >> >> if (ctx->out_type | I80_HW_TRG) { >> >> Also in the same file: >> >> [drivers/gpu/drm/exynos/exynos5433_drm_decon.c:131]: (style) Same expression on both sides of '|'. >> >> Source code is >> >> writel(TRIGCON_TE_AUTO_MASK | TRIGCON_SWTRIGEN >> | TRIGCON_TE_AUTO_MASK | TRIGCON_SWTRIGEN, > In this case, only problem is two flags are set in duplicate. This should be cleaned up. Thanks. :) Wrong copy/paste removed two other flags and duplicated these above. It did not hurt to much as it affects only software trigger which is not used atm. Fix sent yesterday [1]. [1]: http://www.spinics.net/lists/dri-devel/msg134877.html Regards Andrzej > >> Regards >> >> David Binderman >> >> > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel