mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Colin Ian King <colin.king@canonical.com>
To: Kalle Valo <kvalo@codeaurora.org>,
	Carl Huang <cjhuang@codeaurora.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	ath11k@lists.infradead.org,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	netdev@vger.kernel.org
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: re: ath11k: initialize wmi config based on hw_params
Date: Wed, 19 Aug 2020 12:05:17 +0100	[thread overview]
Message-ID: <480d8984-a5fb-be1b-b553-e01609601059@canonical.com> (raw)

Hi,

static analysis with Coverity has detected a duplicated assignment issue
with the following commit:

commit 2d4bcbed5b7d53e19fc158885e7340b464b64507
Author: Carl Huang <cjhuang@codeaurora.org>
Date:   Mon Aug 17 13:31:51 2020 +0300

    ath11k: initialize wmi config based on hw_params

The analysis is as follows:


 74        config->beacon_tx_offload_max_vdev = 0x2;
 75        config->num_multicast_filter_entries = 0x20;
 76        config->num_wow_filters = 0x16;

Unused value (UNUSED_VALUE)
assigned_value: Assigning value 1U to config->num_keep_alive_pattern
here, but that stored value is overwritten before it can be used.
 77        config->num_keep_alive_pattern = 0x1;

value_overwrite: Overwriting previous write to
config->num_keep_alive_pattern with value 0U.

 78        config->num_keep_alive_pattern = 0;


I'm not sure if one of these assignments is redundant, or perhaps one of
the assignments is meant to be setting a different structure element.

Colin

             reply	other threads:[~2020-08-19 11:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19 11:05 Colin Ian King [this message]
2020-09-17 15:04 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=480d8984-a5fb-be1b-b553-e01609601059@canonical.com \
    --to=colin.king@canonical.com \
    --cc=ath11k@lists.infradead.org \
    --cc=cjhuang@codeaurora.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®