From: "dongbo (E)" <dongbo4@huawei.com>
To: <linux-arch@vger.kernel.org>
Cc: <linux-fsdevel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
<catalin.marinas@arm.com>, <will.deacon@arm.com>,
arm-mail-list <linux-arm-kernel@lists.infradead.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: [PATCH REPOST] fs: Preventing READ_IMPLIES_EXEC Propagation
Date: Tue, 25 Apr 2017 14:58:01 +0800 [thread overview]
Message-ID: <481124c6-07ba-4cb8-ca56-fb228b05f796@huawei.com> (raw)
In-Reply-To: <2414e3b3-03f6-bd6c-5aa4-ad58c66b5aa5@huawei.com>
From: Dong Bo <dongbo4@huawei.com>
In load_elf_binary(), once the READ_IMPLIES_EXEC flag is set,
the flag is propagated to its child processes, even the elf
files are marked as not requiring executable stack. It may
cause superfluous operations on some arch, e.g.
__sync_icache_dcache on aarch64 due to a PROT_READ mmap is
also marked as PROT_EXEC.
This patch was originally posted and discussed here:
https://patchwork.kernel.org/patch/9685891/
Signed-off-by: Dong Bo <dongbo4@huawei.com>
---
fs/binfmt_elf.c | 2 ++
fs/binfmt_elf_fdpic.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
index 5075fd5..c52e670 100644
--- a/fs/binfmt_elf.c
+++ b/fs/binfmt_elf.c
@@ -863,6 +863,8 @@ static int load_elf_binary(struct linux_binprm *bprm)
SET_PERSONALITY2(loc->elf_ex, &arch_state);
if (elf_read_implies_exec(loc->elf_ex, executable_stack))
current->personality |= READ_IMPLIES_EXEC;
+ else
+ current->personality &= ~READ_IMPLIES_EXEC;
if (!(current->personality & ADDR_NO_RANDOMIZE) && randomize_va_space)
current->flags |= PF_RANDOMIZE;
diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c
index cf93a4f..c4bc4d0 100644
--- a/fs/binfmt_elf_fdpic.c
+++ b/fs/binfmt_elf_fdpic.c
@@ -354,6 +354,8 @@ static int load_elf_fdpic_binary(struct linux_binprm *bprm)
set_personality(PER_LINUX);
if (elf_read_implies_exec(&exec_params.hdr, executable_stack))
current->personality |= READ_IMPLIES_EXEC;
+ else
+ current->personality &= ~READ_IMPLIES_EXEC;
setup_new_exec(bprm);
-- 1.9.1
.
next prev parent reply other threads:[~2017-04-25 6:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1492088223-98232-1-git-send-email-zhangshaokun@hisilicon.com>
2017-04-13 12:33 ` [PATCH] " dongbo (E)
2017-04-18 17:01 ` Catalin Marinas
2017-04-18 20:01 ` Peter Maydell
2017-04-19 10:33 ` Catalin Marinas
2017-04-19 10:45 ` Peter Maydell
2017-04-20 3:50 ` dongbo (E)
2017-04-24 15:40 ` Will Deacon
2017-04-24 15:58 ` Catalin Marinas
2017-04-24 16:05 ` Will Deacon
2017-04-24 16:14 ` Catalin Marinas
2017-04-25 7:04 ` dongbo (E)
2017-04-25 6:58 ` dongbo (E) [this message]
2017-06-12 13:41 ` [PATCH REPOST] " Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481124c6-07ba-4cb8-ca56-fb228b05f796@huawei.com \
--to=dongbo4@huawei.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=viro@zeniv.linux.org.uk \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®