From: YueHaibing <yuehaibing@huawei.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
<liam.r.girdwood@linux.intel.com>, <yang.jie@linux.intel.com>,
<broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>
Cc: <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH -next] ASoC: Intel: Haswell: Remove set but not used variable 'stage_type'
Date: Thu, 18 Apr 2019 09:25:17 +0800 [thread overview]
Message-ID: <48184039-4c08-ed17-c933-3b697e4aac08@huawei.com> (raw)
In-Reply-To: <ba043cd7-07af-717f-7498-d6bda7d6b79e@linux.intel.com>
On 2019/4/18 1:41, Pierre-Louis Bossart wrote:
> On 4/17/19 10:11 AM, Yue Haibing wrote:
>> From: YueHaibing <yuehaibing@huawei.com>
>>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> sound/soc/intel/haswell/sst-haswell-ipc.c: In function 'hsw_stream_message':
>> sound/soc/intel/haswell/sst-haswell-ipc.c:669:29: warning: variable 'stage_type' set but not used [-Wunused-but-set-variable]
>>
>> It is never used since introduction in
>> commit ba57f68235cf ("ASoC: Intel: create haswell folder and move haswell platform files in")
>
> Thanks for the patch.
>
> I think you could go further in the cleanup and remove both the variable declaration and the static inline mst_get_stage_type that will also be useless as a consequence of this assignment removal.
You are right.
>
> Care to send a v2?
Sure, will do that,thanks!
>
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> sound/soc/intel/haswell/sst-haswell-ipc.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/sound/soc/intel/haswell/sst-haswell-ipc.c b/sound/soc/intel/haswell/sst-haswell-ipc.c
>> index 31fcdf12..4d3de99 100644
>> --- a/sound/soc/intel/haswell/sst-haswell-ipc.c
>> +++ b/sound/soc/intel/haswell/sst-haswell-ipc.c
>> @@ -672,7 +672,6 @@ static int hsw_stream_message(struct sst_hsw *hsw, u32 header)
>> stream_msg = msg_get_stream_type(header);
>> stream_id = msg_get_stream_id(header);
>> - stage_type = msg_get_stage_type(header);
>> stream = get_stream_by_id(hsw, stream_id);
>> if (stream == NULL)
>>
>
>
> .
>
next prev parent reply other threads:[~2019-04-18 1:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 15:11 Yue Haibing
2019-04-17 17:41 ` [alsa-devel] " Pierre-Louis Bossart
2019-04-18 1:25 ` YueHaibing [this message]
2019-04-18 2:48 ` [PATCH v2 " Yue Haibing
2019-04-18 12:54 ` [alsa-devel] " Pierre-Louis Bossart
2019-04-19 16:14 ` Applied "ASoC: Intel: Haswell: Remove set but not used variable 'stage_type'" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48184039-4c08-ed17-c933-3b697e4aac08@huawei.com \
--to=yuehaibing@huawei.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®