mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Miles Lane <miles.lane@gmail.com>
Cc: linux-kernel@vger.kernel.org, Kristian Hoegsberg <krh@redhat.com>,
	linux1394-devel@lists.sourceforge.net
Subject: Re: 2.6.25-git16 -- BUG: unable to handle kernel NULL pointer dereference at 00000000 -- IP: [<c02dd5d5>] fw_show_drv_device_ids+0xd9/0xee
Date: Thu, 01 May 2008 15:44:33 +0200	[thread overview]
Message-ID: <4819C941.6030209@s5r6.in-berlin.de> (raw)
In-Reply-To: <a44ae5cd0805010608n6c441082udd00c315e786de40@mail.gmail.com>

Miles Lane wrote:
> Hi Stefan.  Thanks for your patch.  It worked great.

Good, thanks for reporting and testing.

> Now I see this in the logs:
> 
> ohci1394: fw-host0: SelfID received outside of bus reset sequence
> IEEE 1394 device has ROM CRC error
> IEEE 1394 device has ROM CRC error
> Program usplash tried to access /dev/mem between 0->8000000.
> ieee1394: Node added: ID:BUS[0-00:1023]  GUID[00d0f54000000173]
> ieee1394: Host added: ID:BUS[0-01:1023]  GUID[00e018000027d06c]
> IEEE 1394 device has ROM CRC error
> IEEE 1394 device has ROM CRC error
> IEEE 1394 device has ROM CRC error
> IEEE 1394 device has ROM CRC error
> IEEE 1394 device has ROM CRC error
> 
> Also, "cat /sys/bus/ieee1394/drivers/raw1394/device_ids" no longer
> causes an error.
> 
> Is it necessary for the code to spit out so many CRC errors for the
> OrangeMicro iBot?

I could look into keeping those messages down to only a single one per 
attempt to fetch the so-called configuration ROM of an added node.

> Also, are these errors indicating a significant
> problem with the iBot?

The config ROM is an area in the IEEE 1394 address space of a node which 
contains information about the device functions.  It consists of a 
header, a root directory, and subdirectories.  Each one of those has 
CRCs as one safeguard (among others) against integrity issues with the 
data read from the ROM.

A few devices, especially older ones, got the CRC algorithm wrong. Hence 
we don't reject those devices, we only warn about them as a starting 
point for further diagnosis in case that more than this goes wrong when 
using the device.

(The ROM CRC error warning has been added in 2.6.22.  Before Linux 
2.6.22, the ROM CRC errors were silently accepted.  The new alternative 
firewire drivers also do not warn about ROM CRC errors... yet...)
-- 
Stefan Richter
-=====-==--- -=-= ----=
http://arcgraph.de/sr/

  reply	other threads:[~2008-05-01 13:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-01  0:29 Miles Lane
2008-05-01  8:43 ` Stefan Richter
2008-05-01 13:08   ` Miles Lane
2008-05-01 13:44     ` Stefan Richter [this message]
2008-05-01 14:37       ` Dan Noé
2008-05-01 15:05         ` Stefan Richter
2008-05-02 18:14     ` [PATCH] ieee1394: reduce log noise about config ROM CRC errors Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4819C941.6030209@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=krh@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=miles.lane@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®