mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Andrew G. Morgan" <morgan@kernel.org>
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	linux-security-module@vger.kernel.org,
	Michael Kerrisk <mtk.manpages@gmail.com>
Subject: Re: [PATCH] capabilities: add bounding set to /proc/self/status
Date: Thu, 01 May 2008 17:34:47 -0700	[thread overview]
Message-ID: <481A61A7.6050305@kernel.org> (raw)
In-Reply-To: <20080501183559.GA21279@sergelap.austin.ibm.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Acked-by: Andrew G. Morgan <morgan@kernel.org>

Cheers

Andrew

Serge E. Hallyn wrote:
| There is currently no way to query the bounding set of another
| task.  As there appears to be no security reason not to, and
| as Michael Kerrisk points out the following valid reasons to do
| so exist:
|
| * consistency (I can see all of the other per-thread/process sets in
| /proc/.../status)
| * debugging -- I could imagine that it would make the job of debugging
| an application that uses capabilities a little simpler.
|
| this patch adds the bounding set to /proc/self/status right after
| the effective set.
|
| If at all possible (and if acked by Andrew Morgan) it would be nice to
| get this into the 2.6.26 cycle.  But I realize it probably is too late
| for that.
|
| Signed-off-by: Serge E. Hallyn <serue@us.ibm.com>
| Acked-by: Michael Kerrisk <mtk.manpages@gmail.com>
| ---
|  fs/proc/array.c |    1 +
|  1 files changed, 1 insertions(+), 0 deletions(-)
|
| diff --git a/fs/proc/array.c b/fs/proc/array.c
| index c135cbd..160dd4a 100644
| --- a/fs/proc/array.c
| +++ b/fs/proc/array.c
| @@ -297,6 +297,7 @@ static inline void task_cap(struct seq_file *m,
struct task_struct *p)
|  	render_cap_t(m, "CapInh:\t", &p->cap_inheritable);
|  	render_cap_t(m, "CapPrm:\t", &p->cap_permitted);
|  	render_cap_t(m, "CapEff:\t", &p->cap_effective);
| +	render_cap_t(m, "CapBnd:\t", &p->cap_bset);
|  }
|
|  static inline void task_context_switch_counts(struct seq_file *m,
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)

iD8DBQFIGmGn+bHCR3gb8jsRAlufAJ0eheUXQ1xvB8HofY3KbPIUHqSUXQCeOQf2
pZBx38zkUe7nviE7Z77ns3k=
=lPd5
-----END PGP SIGNATURE-----

  reply	other threads:[~2008-05-02  0:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-01 18:35 Serge E. Hallyn
2008-05-02  0:34 ` Andrew G. Morgan [this message]
2008-05-02  0:38 ` Chris Wright
2008-05-05  8:22   ` Michael Kerrisk
2008-05-05 15:52     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=481A61A7.6050305@kernel.org \
    --to=morgan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=serue@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome