From: Andi Kleen <andi@firstfloor.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH REPOST] CPA: Add statistics about state of direct mapping v4
Date: Mon, 05 May 2008 12:23:45 +0200 [thread overview]
Message-ID: <481EE031.3090303@firstfloor.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0805051208240.3318@apollo.tec.linutronix.de>
>> +static unsigned long direct_pages_count[PG_LEVEL_NUM];
>> +
>> +void __meminit update_page_count(int level, unsigned long pages)
>
> Why __meminit ? This is used in split_large_page()
True. Can you please just remove it? I think it came when this
was still only used in early memory init.
[insert standard rant about the work:code size benefit ratio of these
fine grained section identifiers being far too high]
>> +{
>> +#ifdef CONFIG_PROC_FS
>
> Why keep an empty function when PROC_FS is disabled ?
So we don't have to add a ifdef in all the callers. Yes could probably
have an empty inline in that case in some header, but frankly that would
be a lot of code lines for saving only very minor code size in a very
unlikely CONFIG case.
-Andi
prev parent reply other threads:[~2008-05-05 10:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 9:46 Andi Kleen
2008-05-05 10:13 ` Thomas Gleixner
2008-05-05 10:23 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481EE031.3090303@firstfloor.org \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®