From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74DB7C3E8C5 for ; Fri, 27 Nov 2020 23:06:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B1FD22228 for ; Fri, 27 Nov 2020 23:06:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="G2k+c5Di" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727742AbgK0XGM (ORCPT ); Fri, 27 Nov 2020 18:06:12 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:39432 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729302AbgK0XEd (ORCPT ); Fri, 27 Nov 2020 18:04:33 -0500 Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0001597E; Sat, 28 Nov 2020 00:04:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1606518252; bh=ZyZDfTgfTZ00cnT+cpplrgyxJT8LT1/7yN3ReJNHI4U=; h=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From; b=G2k+c5DiXhUx/XnmeMlGNm3cWqc5ix7Ja85ZAbEh8haviPjsnr8mVFlmU0QfbGqS4 roy24nKYt6UZRsdJLK82OILvxoy3VX3A4eWrWgl+jeAIiRDnWLu1UH1YT5VzNrQqHt vtF8xwO/XoYMlI5jKToLvR/zgfyC17WvwfI/zHQM= Reply-To: kieran.bingham+renesas@ideasonboard.com Subject: Re: [PATCH] net: cisco: remove trailing semicolon in macro definition To: trix@redhat.com, kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org, bigeasy@linutronix.de, mpe@ellerman.id.au, lee.jones@linaro.org, dan.carpenter@oracle.com, adobriyan@gmail.com Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201127175821.2756988-1-trix@redhat.com> From: Kieran Bingham Organization: Ideas on Board Message-ID: <481e5dc2-669d-451c-c405-4cd92e6f8e91@ideasonboard.com> Date: Fri, 27 Nov 2020 23:04:08 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201127175821.2756988-1-trix@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tom, On 27/11/2020 17:58, trix@redhat.com wrote: > From: Tom Rix > > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix Seems to be the only occurrence in this file. Reviewed-by: Kieran Bingham > --- > drivers/net/wireless/cisco/airo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/cisco/airo.c b/drivers/net/wireless/cisco/airo.c > index 74acf9af2adb..ba62bb2995d9 100644 > --- a/drivers/net/wireless/cisco/airo.c > +++ b/drivers/net/wireless/cisco/airo.c > @@ -5785,7 +5785,7 @@ static int airo_get_quality (StatusRid *status_rid, CapabilityRid *cap_rid) > } > > #define airo_get_max_quality(cap_rid) (memcmp((cap_rid)->prodName, "350", 3) ? 0x20 : 0xa0) > -#define airo_get_avg_quality(cap_rid) (memcmp((cap_rid)->prodName, "350", 3) ? 0x10 : 0x50); > +#define airo_get_avg_quality(cap_rid) (memcmp((cap_rid)->prodName, "350", 3) ? 0x10 : 0x50) > > /*------------------------------------------------------------------*/ > /* >