mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Alexei Solcanu <alexei.solcanu@pm.me>
Cc: Cryolitia PukNgae <cryolitia@uniontech.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, Antheas Kapenekakis <lkml@antheas.dev>
Subject: Re: [PATCH v2 1/2] hwmon: (gpd-fan) Reset both fans to automatic on duo boards
Date: Mon, 26 Oct 2026 13:57:24 -0700	[thread overview]
Message-ID: <481ec234-15a1-45df-9e7b-9c280ddde9a3@roeck-us.net> (raw)
In-Reply-To: <20260926-gpd-fan-duo-auto-v2-1-0a2ea41ee3b5@pm.me>

On Sat, Sep 26, 2026 at 04:11:20PM -0400, Alexei Solcanu wrote:
> From: Alexei Solcanu <alexei.solcanu@pm.me>
> 
> On boards using gpd_duo_drvdata (GPD Duo, GPD Win 5), writing
> pwm1_enable=2 only returns the first fan to EC control. The second fan
> keeps its last manual duty cycle, e.g. full speed after pwm1=255, so a
> fan control tool that exits leaves it running at that speed.
> 
> gpd_duo_write_pwm() writes both fan registers (pwm_write and
> pwm_write + 1), but switching to automatic only clears pwm_write.
> Also clear pwm_write + 1, so both fans return to EC control.
> 
> Tested on a GPD Win 5 (G1618-05). Not tested on the GPD Duo.
> 
> Fixes: 0ab88e239439 ("hwmon: add GPD devices sensor driver")
> Assisted-by: LLM
> Signed-off-by: Alexei Solcanu <alexei.solcanu@pm.me>
> Reviewed-by: Antheas Kapenekakis <lkml@antheas.dev>

Applied.

Thanks,
Guenter

  parent reply	other threads:[~2026-10-26 20:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-26 20:11 [PATCH v2 0/2] hwmon: (gpd-fan) Fix the second fan on duo boards, split Win 5 fans Alexei Solcanu via B4 Relay
2026-09-26 20:11 ` [PATCH v2 1/2] hwmon: (gpd-fan) Reset both fans to automatic on duo boards Alexei Solcanu via B4 Relay
2026-09-26 20:22   ` Antheas Kapenekakis
2026-10-26 20:57   ` Guenter Roeck [this message]
2026-09-26 20:11 ` [PATCH v2 2/2] hwmon: (gpd-fan) Register both fans on the GPD Win 5 Alexei Solcanu via B4 Relay
2026-09-26 20:32   ` Antheas Kapenekakis
2026-09-26 21:36     ` Alexei Solcanu
2026-09-26 21:52       ` Antheas Kapenekakis
2026-09-26 22:15         ` Alexei Solcanu
2026-09-28 11:05   ` Guenter Roeck
2026-09-28 12:03     ` Antheas Kapenekakis
2026-09-28 14:30       ` Guenter Roeck
2026-09-28 13:32     ` Alexei Solcanu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=481ec234-15a1-45df-9e7b-9c280ddde9a3@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=alexei.solcanu@pm.me \
    --cc=corbet@lwn.net \
    --cc=cryolitia@uniontech.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@antheas.dev \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®