From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751823AbeAEMED (ORCPT + 1 other); Fri, 5 Jan 2018 07:04:03 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:37062 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751254AbeAEMEB (ORCPT ); Fri, 5 Jan 2018 07:04:01 -0500 X-Google-Smtp-Source: ACJfBouyzx7S0kBtmHDObJS22N+I7BLg/LEFu/oQUUV1xuJN96EWqzbgOT0QIzguewvgamftnUskxA== Subject: Re: [PATCH] media: staging: tegra-vde: select DMA_SHARED_BUFFER To: Arnd Bergmann , Mauro Carvalho Chehab Cc: Greg Kroah-Hartman , Thierry Reding , Jonathan Hunter , Hans Verkuil , linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <20180105094343.2813148-1-arnd@arndb.de> From: Dmitry Osipenko Message-ID: <481fe121-8937-81a5-40d5-d8fe8a0036dd@gmail.com> Date: Fri, 5 Jan 2018 15:03:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180105094343.2813148-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 05.01.2018 12:43, Arnd Bergmann wrote: > Without CONFIG_DMA_SHARED_BUFFER we run into a link error for the > dma_buf_* APIs: > > ERROR: "dma_buf_map_attachment" [drivers/staging/media/tegra-vde/tegra-vde.ko] undefined! > ERROR: "dma_buf_attach" [drivers/staging/media/tegra-vde/tegra-vde.ko] undefined! > ERROR: "dma_buf_get" [drivers/staging/media/tegra-vde/tegra-vde.ko] undefined! > ERROR: "dma_buf_put" [drivers/staging/media/tegra-vde/tegra-vde.ko] undefined! > ERROR: "dma_buf_detach" [drivers/staging/media/tegra-vde/tegra-vde.ko] undefined! > ERROR: "dma_buf_unmap_attachment" [drivers/staging/media/tegra-vde/tegra-vde.ko] undefined! > > Signed-off-by: Arnd Bergmann > --- > drivers/staging/media/tegra-vde/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/media/tegra-vde/Kconfig b/drivers/staging/media/tegra-vde/Kconfig > index ec3ddddebdaa..5c4914674468 100644 > --- a/drivers/staging/media/tegra-vde/Kconfig > +++ b/drivers/staging/media/tegra-vde/Kconfig > @@ -1,6 +1,7 @@ > config TEGRA_VDE > tristate "NVIDIA Tegra Video Decoder Engine driver" > depends on ARCH_TEGRA || COMPILE_TEST > + select DMA_SHARED_BUFFER > select SRAM > help > Say Y here to enable support for the NVIDIA Tegra video decoder > Thanks! Acked-by: Dmitry Osipenko