From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751648AbdHAXVo (ORCPT ); Tue, 1 Aug 2017 19:21:44 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:50046 "EHLO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750854AbdHAXVm (ORCPT ); Tue, 1 Aug 2017 19:21:42 -0400 From: "Rafael J. Wysocki" To: Borislav Petkov , Loc Ho Cc: msalter@redhat.com, rafael@kernel.org, tbaicar@codeaurora.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patches@apm.com Subject: Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ Date: Wed, 02 Aug 2017 01:13:34 +0200 Message-ID: <4821934.osN6riWrO9@aspire.rjw.lan> User-Agent: KMail/4.14.10 (Linux/4.12.0-rc1+; KDE/4.14.9; x86_64; ; ) In-Reply-To: <20170722055954.GA2082@nazgul.tnic> References: <1500661477-6536-1-git-send-email-lho@apm.com> <1500661477-6536-2-git-send-email-lho@apm.com> <20170722055954.GA2082@nazgul.tnic> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, July 22, 2017 07:59:54 AM Borislav Petkov wrote: > On Fri, Jul 21, 2017 at 11:24:37AM -0700, Loc Ho wrote: > > X-Gene platforms describe multiple GHES error sources with the same hardware > > error notification type (external interrupt) and interrupt number. > > Change the GHES interrupt request to support sharing the same IRQ. > > > > Co-authored-by: Tuan Phan > > Signed-off-by: Loc Ho > > --- > > drivers/acpi/apei/ghes.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > > index d661d45..eed09fc 100644 > > --- a/drivers/acpi/apei/ghes.c > > +++ b/drivers/acpi/apei/ghes.c > > @@ -1157,7 +1157,8 @@ static int ghes_probe(struct platform_device *ghes_dev) > > generic->header.source_id); > > goto err_edac_unreg; > > } > > - rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes); > > + rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED, > > + "GHES IRQ", ghes); > > if (rc) { > > pr_err(GHES_PFX "Failed to register IRQ for generic hardware error source: %d\n", > > generic->header.source_id); > > Acked-by: Borislav Petkov Applied, thanks!