From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755438AbdGKLj0 (ORCPT ); Tue, 11 Jul 2017 07:39:26 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:31677 "EHLO lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752577AbdGKLjZ (ORCPT ); Tue, 11 Jul 2017 07:39:25 -0400 Subject: Re: [PATCH v10 0/3] mm: security: ro protection for dynamic data To: Tetsuo Handa , , , , , , , CC: , , , , , References: <20170710150603.387-1-igor.stoppa@huawei.com> <201707112012.GBC05774.QOtOSLJVFHFOFM@I-love.SAKURA.ne.jp> From: Igor Stoppa Message-ID: <4821f909-8885-654d-701e-3044c79d055f@huawei.com> Date: Tue, 11 Jul 2017 14:37:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <201707112012.GBC05774.QOtOSLJVFHFOFM@I-love.SAKURA.ne.jp> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.122.225.51] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020205.5964B8C1.0182,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 67c6093b1ec9d5dcbe24637c62b3729a Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/07/17 14:12, Tetsuo Handa wrote: > Igor Stoppa wrote: >> - I had to rebase Tetsuo Handa's patch because it didn't apply cleanly >> anymore, I would appreciate an ACK to that or a revised patch, whatever >> comes easier. > > Since we are getting several proposals of changing LSM hooks and both your proposal > and Casey's "LSM: Security module blob management" proposal touch same files, I think > we can break these changes into small pieces so that both you and Casey can make > future versions smaller. > > If nobody has objections about direction of Igor's proposal and Casey's proposal, > I think merging only "[PATCH 2/3] LSM: Convert security_hook_heads into explicit > array of struct list_head" from Igor's proposal and ->security accessor wrappers (e.g. I would like to understand if there is still interest about: * "[PATCH 1/3] Protectable memory support" which was my main interest * "[PATCH 3/3] Make LSM Writable Hooks a command line option" which was the example of how to use [1/3] > #define selinux_security(obj) (obj->security) > #define smack_security(obj) (obj->security) > #define tomoyo_security(obj) (obj->security) > #define apparmor_security(obj) (obj->security) For example, I see that there are various kzalloc calls that might be useful to turn into pmalloc ones. In general, I'd think that, after a transient is complete, where modules are loaded by allocating dynamic data structures, they could be locked down in read-only mode. I have the feeling that, now that I have polished up the pmalloc patch, the proposed use case is fading away. Can it be adjusted to the new situation or should I look elsewhere for an example that would justify merging pmalloc? thanks, igor