From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935284AbdAEVJK (ORCPT <rfc822;w@1wt.eu>);
        Thu, 5 Jan 2017 16:09:10 -0500
Received: from fllnx210.ext.ti.com ([198.47.19.17]:24752 "EHLO
        fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752283AbdAEVJB (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 5 Jan 2017 16:09:01 -0500
Subject: Re: [PATCH v2] soc: ti: Drop wait from wkup_m3_rproc_boot_thread
To: Sarangdhar Joshi <spjoshi@codeaurora.org>,
        Ohad Ben-Cohen <ohad@wizery.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Santosh Shilimkar <ssantosh@kernel.org>,
        Tony Lindgren <tony@atomide.com>,
        Santosh Shilimkar <ssantosh@kernel.org>
References: <1483486889-3662-1-git-send-email-spjoshi@codeaurora.org>
CC: <linux-remoteproc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-arm-msm@vger.kernel.org>, Stephen Boyd <sboyd@codeaurora.org>,
        Trilok Soni <tsoni@codeaurora.org>, Dave Gerlach <d-gerlach@ti.com>
From: Suman Anna <s-anna@ti.com>
Message-ID: <482666d0-7915-ead2-c514-2651a4967a43@ti.com>
Date: Thu, 5 Jan 2017 15:08:28 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <1483486889-3662-1-git-send-email-spjoshi@codeaurora.org>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/03/2017 05:41 PM, Sarangdhar Joshi wrote:
> The function wkup_m3_rproc_boot_thread waits for
> asynchronous firmware loading to parse the resource table
> before calling rproc_boot(). However, as the resource table
> parsing has been moved to rproc_boot(), there's no need to
> wait for the asynchronous firmware loading completion.
> So, drop this.
> 
> CC: Dave Gerlach <d-gerlach@ti.com>
> CC: Suman Anna <s-anna@ti.com>
> CC: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>

+ Tony and Santosh, not sure who is picking up the wkup_m3 related patches.

Only one minor nit, I would prefer the patch subject to start with
soc: ti: wkup_m3_ipc: ....

Tested-by: Suman Anna <s-anna@ti.com>

regards
Suman

> ---
> 
> This patch seems to be doing an independent clean up now. Hence
> removing it from the series.
> 
>  drivers/soc/ti/wkup_m3_ipc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
> index 8823cc8..8bfa44b 100644
> --- a/drivers/soc/ti/wkup_m3_ipc.c
> +++ b/drivers/soc/ti/wkup_m3_ipc.c
> @@ -370,8 +370,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
>  	struct device *dev = m3_ipc->dev;
>  	int ret;
>  
> -	wait_for_completion(&m3_ipc->rproc->firmware_loading_complete);
> -
>  	init_completion(&m3_ipc->sync_complete);
>  
>  	ret = rproc_boot(m3_ipc->rproc);
>