From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752009AbdJYGFO (ORCPT ); Wed, 25 Oct 2017 02:05:14 -0400 Received: from mout.web.de ([212.227.15.4]:59739 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751162AbdJYGFL (ORCPT ); Wed, 25 Oct 2017 02:05:11 -0400 Subject: Re: hwmon/amc6821: Use common error handling code in amc6821_init_client() To: =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= , linux-hwmon@vger.kernel.org Cc: Jean Delvare , LKML , kernel-janitors@vger.kernel.org References: <8cc80503-aa2b-bb5e-ab40-fa31b401b6a2@users.sourceforge.net> <20171024201812.GA5769@roeck-us.net> From: SF Markus Elfring Message-ID: <482baa1b-ea2d-76db-3aee-719b6645156c@users.sourceforge.net> Date: Wed, 25 Oct 2017 08:03:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171024201812.GA5769@roeck-us.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:+FmzE/l2jgSq7TfELkC24JmyvK/WEusedozJxK4pLIkKLjehYHp sLq1ZU4ojgh6djwkatS78b8nTisgxBwOJ5NPzgmLOdBtvlmfsunZIp32/KWXmTSVEessIZR HYodYTZwrgybLvSMEZ2X5gHv9GxiHeyLOrzDWYvY7Qyw3ZMuyAOrdCidw2bgrRKvNeDWkik SjXTXI16bM8ExIXNqmdkg== X-UI-Out-Filterresults: notjunk:1;V01:K0:q/2yOF9FfkA=:ZgNGVlOAxHZHVJCWxGfjZc IlIYeV4yfCDkCGhd1gKXHi6hRFvjPOCUsF63zrM7zsYz/xwpLXcgxRkQMGrf0ih/dAi/TUnl6 syD9webXnPr26Nho6ln9TDk2HmNbqX/zoSIn8Hv10PbNYhipltUR2y9rQosBL9WogU1ZWgmJv VAKX6avu6FoEXl8KXILzFmOPBQSBtiGdfsLWYifYcEnYFjOBXuxunBkNxZVU8xluXKMGYhBMt pESIE5UMNm/iVZAByabquPY8eeCSlNd8AzEWS3IjwOWA4nIWsNfEpVOJ9946mJ47stuSSYGLJ DhilVbpXwEfD4oeW83tW+3zflNDCbNRHXUqBqRBd2Z5dB0jVhEpNWOBa1h71K3yn/aFkaGdsg h0M4SJDuelbEUudvKDI5oEDGKlAc1+TjozsKmnUxxMnooN+czaYdrW2qn8rhNDu85N5LijivW Ht83AzV0Isz0fERJ9/lpU4hJYQCEZhakKF4unennwnw/y/dqoG+pZYPN/muWDP9y8IhaFr0y1 v4Bf+V2oJ6Bs2plKDw/Ds1WPUo6PmADV98cVi+BoVa+Baa0QDZpFRhgltWqExBE6Nq0mzHu/3 47DNY1NsdIS/RDQLFqE4X1KDaqWbeeKmJ2E48pFcgsA16yjR4JV5VQTdUjQtm4OrWMXUthEZS /DEes2uXE4HvlSYh3DXbB5IV5nOWjYUTrNJ27MAwjlaLxF4IYEKwgZJH9nAFHYip7C8qouwHA FHYdjo9sQFQoStd7TdKsJBhthHRUj0tZpGOCH/BfJodqVF7KPEGt6fy50xdHM6rpeOKNeaGhV 1LMu1K2Da6JbM3KwLzP4tnP7HnGJv0zIQPQLQZf8BTcIzxYGsk= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Nack; I am not a friend of that much verboseness to start with, > and I don't think the patch improves readability. * Do you care to avoid code duplication for two error messages in this use case? * How do you think about to return a single error code directly without using an intermediate variable? Regards, Markus