From: Aradhya Bhatia <a-bhatia1@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Devarsh Thakkar <devarsht@ti.com>, Jyri Sarha <jyri.sarha@iki.fi>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Francesco Dolcini <francesco@dolcini.it>,
<stable@vger.kernel.org>
Subject: Re: [PATCH v2 00/11] drm/tidss: Probe related fixes and cleanups
Date: Fri, 1 Dec 2023 11:54:04 +0530 [thread overview]
Message-ID: <482d9ad7-86b6-48a9-8dab-5502ce1a5384@ti.com> (raw)
In-Reply-To: <20231109-tidss-probe-v2-0-ac91b5ea35c0@ideasonboard.com>
Hi Tomi,
Thank you for the patches!
On 09/11/23 13:07, Tomi Valkeinen wrote:
> While working on the TI BSP kernel, adding bootload splash screen
> support, I noticed some issues with the driver and opportunities for
> cleanups and improvements.
>
> Tomi
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> ---
> Changes in v2:
> - Add missing pm_runtime_dont_use_autosuspend() in error path
> - Add simple manual "reset" for K2G
> - Leave tidss->dispc NULL if dispc_init fails
> - Add Fixes tags
> - Drop "drm/tidss: Add dispc_is_idle()"
> - Add "drm/tidss: Use DRM_PLANE_COMMIT_ACTIVE_ONLY"
> - Link to v1: https://lore.kernel.org/r/20231101-tidss-probe-v1-0-45149e0f9415@ideasonboard.com
>
> ---
> Tomi Valkeinen (11):
> drm/tidss: Use pm_runtime_resume_and_get()
> drm/tidss: Use PM autosuspend
> drm/tidss: Drop useless variable init
> drm/tidss: Move reset to the end of dispc_init()
> drm/tidss: Return error value from from softreset
> drm/tidss: Check for K2G in in dispc_softreset()
> drm/tidss: Add simple K2G manual reset
> drm/tidss: Fix dss reset
> drm/tidss: IRQ code cleanup
> drm/tidss: Fix atomic_flush check
> drm/tidss: Use DRM_PLANE_COMMIT_ACTIVE_ONLY
For the series,
Reviewed-by: Aradhya Bhatia <a-bhatia1@ti.com>
Regards
Aradhya
>
> drivers/gpu/drm/tidss/tidss_crtc.c | 12 ++----
> drivers/gpu/drm/tidss/tidss_dispc.c | 79 +++++++++++++++++++++++++++++++++----
> drivers/gpu/drm/tidss/tidss_drv.c | 15 +++++--
> drivers/gpu/drm/tidss/tidss_irq.c | 54 ++++---------------------
> drivers/gpu/drm/tidss/tidss_kms.c | 2 +-
> 5 files changed, 97 insertions(+), 65 deletions(-)
> ---
> base-commit: 9d7c8c066916f231ca0ed4e4fce6c4b58ca3e451
> change-id: 20231030-tidss-probe-854b1098c3af
>
> Best regards,
prev parent reply other threads:[~2023-12-01 6:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 7:37 Tomi Valkeinen
2023-11-09 7:37 ` [PATCH v2 01/11] drm/tidss: Use pm_runtime_resume_and_get() Tomi Valkeinen
2023-11-09 7:37 ` [PATCH v2 02/11] drm/tidss: Use PM autosuspend Tomi Valkeinen
2023-11-09 7:37 ` [PATCH v2 03/11] drm/tidss: Drop useless variable init Tomi Valkeinen
2023-11-09 7:37 ` [PATCH v2 04/11] drm/tidss: Move reset to the end of dispc_init() Tomi Valkeinen
2023-11-09 7:37 ` [PATCH v2 05/11] drm/tidss: Return error value from from softreset Tomi Valkeinen
2023-11-09 7:37 ` [PATCH v2 06/11] drm/tidss: Check for K2G in in dispc_softreset() Tomi Valkeinen
2023-11-09 7:38 ` [PATCH v2 07/11] drm/tidss: Add simple K2G manual reset Tomi Valkeinen
2023-11-09 7:38 ` [PATCH v2 08/11] drm/tidss: Fix dss reset Tomi Valkeinen
2023-11-09 7:38 ` [PATCH v2 09/11] drm/tidss: IRQ code cleanup Tomi Valkeinen
2023-11-09 7:38 ` [PATCH v2 10/11] drm/tidss: Fix atomic_flush check Tomi Valkeinen
2023-11-09 7:38 ` [PATCH v2 11/11] drm/tidss: Use DRM_PLANE_COMMIT_ACTIVE_ONLY Tomi Valkeinen
2023-12-01 6:24 ` Aradhya Bhatia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482d9ad7-86b6-48a9-8dab-5502ce1a5384@ti.com \
--to=a-bhatia1@ti.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devarsht@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=francesco@dolcini.it \
--cc=jyri.sarha@iki.fi \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®