From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B888CD4848 for ; Fri, 22 Sep 2023 16:57:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229801AbjIVQ5d (ORCPT ); Fri, 22 Sep 2023 12:57:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230443AbjIVQ50 (ORCPT ); Fri, 22 Sep 2023 12:57:26 -0400 Received: from mail.z3ntu.xyz (mail.z3ntu.xyz [128.199.32.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84DFB198; Fri, 22 Sep 2023 09:57:18 -0700 (PDT) Received: from g550jk.localnet (k10064.upc-k.chello.nl [62.108.10.64]) by mail.z3ntu.xyz (Postfix) with ESMTPSA id 01F29CFADA; Fri, 22 Sep 2023 16:56:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=z3ntu.xyz; s=z3ntu; t=1695401807; bh=rK5mAbbiQpqlLCWKbud4SA+Xd793oMxnhhSEUiqVv/w=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=TaNlayt6gRWpSNQ0zSytpOvDi8n403zBwEqlSZfulE94+TaduxD2u4h1t+k0+5vQq 0SA9PpSvKSoHvNRP9XzPySVYsbJ1EARl00BFMI3t5e1p59bWQDmwu+8GoyuRxuWp2D gMjmQx2UVwyFVFM2G9Ve9Q1Dm1aXGLmZQ7JlWQLE= From: Luca Weiss To: Konrad Dybcio , Bjorn Andersson Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Andy Gross , Rob Herring , Krzysztof Kozlowski , Eduardo Valentin , Conor Dooley , Rajendra Nayak , Rob Herring , Andy Gross , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Craig Tatlor Subject: Re: [PATCH v2] ARM: dts: qcom: msm8974: correct qfprom node size Date: Fri, 22 Sep 2023 18:56:46 +0200 Message-ID: <4831735.GXAFRqVoOG@z3ntu.xyz> In-Reply-To: <12394955.O9o76ZdvQC@z3ntu.xyz> References: <20230130-msm8974-qfprom-v2-1-3839cf41d9ee@z3ntu.xyz> <12394955.O9o76ZdvQC@z3ntu.xyz> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sonntag, 6. August 2023 12:47:51 CEST Luca Weiss wrote: > Hi Bjorn, > > On Montag, 31. Juli 2023 23:45:21 CEST Bjorn Andersson wrote: > > On Thu, Jun 15, 2023 at 08:20:41PM +0200, Konrad Dybcio wrote: > > > On 15.06.2023 20:17, Luca Weiss wrote: > > > > From: Craig Tatlor > > > > > > > > The qfprom actually has size 0x3000, so adjust the reg. > > > > > > > > Note that the non-ECC-corrected qfprom can be found at 0xfc4b8000 > > > > (-0x4000). The current reg points to the ECC-corrected qfprom block > > > > which should have equivalent values at all offsets compared to the > > > > non-corrected version. > > > > > > > > [luca@z3ntu.xyz: extract to standalone patch and adjust for review > > > > comments] > > > > > > > > Fixes: c59ffb519357 ("arm: dts: msm8974: Add thermal zones, tsens and > > > > qfprom nodes") Signed-off-by: Craig Tatlor > > > > Signed-off-by: Luca Weiss > > > > --- > > > > > > Not sure of the actual size of the region, maybe Bjorn can help.. > > > > > > Downstream 3.10 suggests 0x60F0, 0x20F0 after adjusting for the ECC > > > offset > > > > There is indeed 0x3000 bytes until the next region, but afaict the > > corrected ECC values only cover the first 0x800 bytes thereof. > > > > Can you please let me know if this patch fixes a problem, or just > > makes the numbers look better? > > Initially this patch came from a different direction, to make space to use > the PVS bits for cpufreq. Since Konrad said in earlier revisions that I > should always use the +0x4000 space for the ECC-corrected variant I've > switched to that. > > If you think it's not useful to have the qfprom size reflect the actual > size, we can also drop this patch since I don't think it's actually > necessary for anything that I have lying around in some branches. > > I think I've just sent the current patch to make sure the hardware > description (dts) is as accurate as possible, but of course since any info > on Qualcomm is very restricted it could also be a bit wrong. Hi Bjorn, this patch is still lying in my inbox. Do you think it's correct or incorrect - so should we drop it? Regards Luca > > Regards > Luca > > > Regards, > > Bjorn > > > > > Konrad > > > > > > > Changes in v2: > > > > - Keep base offset but expand reg from 0x1000 to 0x3000 (Konrad) > > > > - Link to v1: > > > > https://lore.kernel.org/r/20230130-msm8974-qfprom-v1-1-975aa0e5e083@z3 > > > > n > > > > tu.xyz --- > > > > > > > > arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi > > > > b/arch/arm/boot/dts/qcom-msm8974.dtsi index 7ed0d925a4e9..3156fe25967f > > > > 100644 > > > > --- a/arch/arm/boot/dts/qcom-msm8974.dtsi > > > > +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi > > > > @@ -1194,7 +1194,7 @@ restart@fc4ab000 { > > > > > > > > qfprom: qfprom@fc4bc000 { > > > > > > > > compatible = "qcom,msm8974-qfprom", > > "qcom,qfprom"; > > > > > - reg = <0xfc4bc000 0x1000>; > > > > + reg = <0xfc4bc000 0x3000>; > > > > > > > > #address-cells = <1>; > > > > #size-cells = <1>; > > > > > > > > --- > > > > base-commit: 858fd168a95c5b9669aac8db6c14a9aeab446375 > > > > change-id: 20230130-msm8974-qfprom-619c0e8f26eb > > > > > > > > Best regards,