From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Thomas Gleixner <tglx@linutronix.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Alexander Viro <viro@ftp.linux.org.uk>,
linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH, RFC] Char dev BKL pushdown v2
Date: Mon, 19 May 2008 21:27:00 +0200 [thread overview]
Message-ID: <4831D484.10505@s5r6.in-berlin.de> (raw)
In-Reply-To: <4831BD08.6030600@s5r6.in-berlin.de>
I wrote:
> Jonathan Corbet wrote:
>> drivers/ieee1394/dv1394.c | 6 +++-
>> drivers/ieee1394/raw1394.c | 3 ++
>> drivers/ieee1394/video1394.c | 18 +++++++++---
> ...
>> ieee1394: cdev lock_kernel() pushdown
>
> I have yet to look at these drivers in detail whether they need BKL or
> not. They likely don't.
video1394 needs it to serialize module init vs. open. The race
condition there can be prevented by splitting hpsb_register_highlevel()
into an _init and a _register function. I will follow up with a patch.
dv1394 and raw1394 do not need the BKL in their open() methods AFAICS.
--
Stefan Richter
-=====-==--- -=-= =--==
http://arcgraph.de/sr/
next prev parent reply other threads:[~2008-05-19 19:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-18 22:15 Jonathan Corbet
2008-05-19 4:00 ` Roland Dreier
2008-05-19 13:37 ` Jonathan Corbet
2008-05-19 20:38 ` Roland Dreier
2008-05-19 20:42 ` Jonathan Corbet
2008-05-19 22:18 ` Roland Dreier
2008-05-19 22:56 ` Jonathan Corbet
2008-05-20 2:10 ` Jeff Dike
2008-05-20 8:26 ` Alan Cox
2008-05-19 4:03 ` Stephen Rothwell
2008-05-19 13:46 ` Jonathan Corbet
2008-05-19 13:17 ` Ingo Molnar
2008-05-19 17:46 ` Stefan Richter
2008-05-19 19:27 ` Stefan Richter [this message]
2008-05-19 20:07 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4831D484.10505@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®