From: Arnd Bergmann <arnd@arndb.de>
To: Hans Ulli Kroll <ulli.kroll@googlemail.com>
Cc: Paul Bolle <pebolle@tiscali.nl>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 1/1] RTC:driver for Cortina's SOC
Date: Wed, 13 May 2015 21:05:54 +0200 [thread overview]
Message-ID: <48345244.4lEG5ioxP8@wuerfel> (raw)
In-Reply-To: <4603623.ImT6VbfUHq@wuerfel>
On Wednesday 13 May 2015 21:03:29 Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> To: Hans Ulli Kroll <ulli.kroll@googlemail.com>
> CC: Paul Bolle <pebolle@tiscali.nl>, Alexandre Belloni <alexandre.belloni@free-electrons.com>, linux-kernel@vger.kernel.org
> Date: Today 21:03:29
> On Wednesday 13 May 2015 20:23:40 Hans Ulli Kroll wrote:
> > > I have a patch that will turn mach-gemini into multiplatform, and
> > > at that point it will also fail there. The correct solution I think
> > > is to move the GEMINI_RTC_SECOND etc definitions into rtc-gemini.c
> > > itself and remove the #include.
> > >
> >
> > GEMINI_RTC_SECOND and other register offset are in the driver.
> > The only address I get from the #include is the base address of the RTC
> >
>
> Ah, I see. Please pass a struct resource for this then when you call
> platform_device_register_simple from the platform code, and
> use platform_get_resource/devm_ioremap_resource to map it so you can
> remove that inclusion.
I just saw that you already do this, so the #include should not be needed at all.
Arnd
next prev parent reply other threads:[~2015-05-13 19:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 16:25 [PATCHv2] " Hans Ulli Kroll
2015-05-11 16:25 ` [PATCHv2 1/1] " Hans Ulli Kroll
2015-05-12 9:05 ` Paul Bolle
2015-05-12 9:28 ` Arnd Bergmann
2015-05-13 18:23 ` Hans Ulli Kroll
2015-05-13 19:03 ` Arnd Bergmann
2015-05-13 19:05 ` Arnd Bergmann [this message]
2015-05-12 9:17 ` [PATCHv2] " Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48345244.4lEG5ioxP8@wuerfel \
--to=arnd@arndb.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome