From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC9AAC433FE for ; Fri, 15 Apr 2022 06:27:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349432AbiDOGaV (ORCPT ); Fri, 15 Apr 2022 02:30:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236018AbiDOGaT (ORCPT ); Fri, 15 Apr 2022 02:30:19 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8ACDDDF56; Thu, 14 Apr 2022 23:27:51 -0700 (PDT) X-UUID: 037575d748144b85a8b83871af7e718a-20220415 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.4,REQID:3eab5806-633f-4f1d-9991-14a74b903715,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:27,FILE:0,RULE:Release_Ham,ACT ION:release,TS:27 X-CID-INFO: VERSION:1.1.4,REQID:3eab5806-633f-4f1d-9991-14a74b903715,OB:0,LOB: 0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:27,FILE:0,RULE:Release_UHam,ACTI ON:release,TS:27 X-CID-META: VersionHash:faefae9,CLOUDID:6a1a3ba9-d103-4e36-82b9-b0e86991b3df,C OID:IGNORED,Recheck:0,SF:13|15|28|100|16|18|48|101,TC:nil,Content:0,EDM:-3 ,File:nil,QS:0,BEC:nil X-UUID: 037575d748144b85a8b83871af7e718a-20220415 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 297101346; Fri, 15 Apr 2022 14:27:46 +0800 Received: from mtkexhb01.mediatek.inc (172.21.101.102) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Fri, 15 Apr 2022 14:27:45 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb01.mediatek.inc (172.21.101.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 15 Apr 2022 14:27:44 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 15 Apr 2022 14:27:44 +0800 Message-ID: <48380a5b06ce48c4538e6c89bc6399ba1f425718.camel@mediatek.com> Subject: Re: [PATCH v18 07/10] drm/mediatek: add mediatek-drm of vdosys0 support for mt8195 From: Jason-JH Lin To: kernel test robot , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Chun-Kuang Hu , AngeloGioacchino Del Regno CC: , , , Maxime Coquelin , "David Airlie" , , , , , , , Fabien Parent , , , Yongqiang Niu , , Rex-BC Chen , , Date: Fri, 15 Apr 2022 14:27:44 +0800 In-Reply-To: <202204142333.qXgcGMI1-lkp@intel.com> References: <20220412103114.19922-8-jason-jh.lin@mediatek.com> <202204142333.qXgcGMI1-lkp@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi "kernel test robot", Thanks for the reviews. On Thu, 2022-04-14 at 23:31 +0800, kernel test robot wrote: > Hi "jason-jh.lin", > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on drm/drm-next] > [also build test WARNING on robh/for-next krzk/for-next linus/master > v5.18-rc2 next-20220414] > [If your patch is applied to the wrong git tree, kindly drop us a > note. > And when submitting patch, we suggest to use '--base' as documented > in > https://urldefense.com/v3/__https://git-scm.com/docs/git-format-patch__;!!CTRNKA9wMg0ARbw!1fp3H7fjidBzBzfT64rjyCv4-HN-czQi_52IEZTo18hsph4srdLAEfrGamKBaGS9DHJM$ > ] > > url: > https://urldefense.com/v3/__https://github.com/intel-lab-lkp/linux/commits/jason-jh-lin/Add-Mediatek-Soc-DRM-vdosys0-support-for-mt8195/20220412-183359__;!!CTRNKA9wMg0ARbw!1fp3H7fjidBzBzfT64rjyCv4-HN-czQi_52IEZTo18hsph4srdLAEfrGamKBaP5NY9rw$ > > base: git://anongit.freedesktop.org/drm/drm drm-next > config: arm64-buildonly-randconfig-r001-20220413 ( > https://urldefense.com/v3/__https://download.01.org/0day-ci/archive/20220414/202204142333.qXgcGMI1-lkp@intel.com/config__;!!CTRNKA9wMg0ARbw!1fp3H7fjidBzBzfT64rjyCv4-HN-czQi_52IEZTo18hsph4srdLAEfrGamKBaMatHhNq$ > ) > compiler: clang version 15.0.0 ( > https://urldefense.com/v3/__https://github.com/llvm/llvm-project__;!!CTRNKA9wMg0ARbw!1fp3H7fjidBzBzfT64rjyCv4-HN-czQi_52IEZTo18hsph4srdLAEfrGamKBaED4pz5K$ > $ 6b7e6ea489f6dd45a9b0da9ac20871560917b9b0) > reproduce (this is a W=1 build): > wget > https://urldefense.com/v3/__https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross__;!!CTRNKA9wMg0ARbw!1fp3H7fjidBzBzfT64rjyCv4-HN-czQi_52IEZTo18hsph4srdLAEfrGamKBaGF0WqUy$ > -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install arm64 cross compiling tool for clang build > # apt-get install binutils-aarch64-linux-gnu > # > https://urldefense.com/v3/__https://github.com/intel-lab-lkp/linux/commit/7c175317aa80bbc885609a730214448147a46b47__;!!CTRNKA9wMg0ARbw!1fp3H7fjidBzBzfT64rjyCv4-HN-czQi_52IEZTo18hsph4srdLAEfrGamKBaN_w7rr0$ > > git remote add linux-review > https://urldefense.com/v3/__https://github.com/intel-lab-lkp/linux__;!!CTRNKA9wMg0ARbw!1fp3H7fjidBzBzfT64rjyCv4-HN-czQi_52IEZTo18hsph4srdLAEfrGamKBaMen_Lno$ > > git fetch --no-tags linux-review jason-jh-lin/Add-Mediatek- > Soc-DRM-vdosys0-support-for-mt8195/20220412-183359 > git checkout 7c175317aa80bbc885609a730214448147a46b47 > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross > W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/gpu/drm/mediatek/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > drivers/gpu/drm/mediatek/mtk_drm_drv.c:707:15: warning: cast to > smaller integer type 'enum mtk_ddp_comp_type' from 'const void *' [- > Wvoid-pointer-to-enum-cast] > comp_type = (enum mtk_ddp_comp_type)of_id->data; > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I can't reproduce this build warning in my platform, but I'd found the same warning fixed patch: 20210928154620.11181-4-cgzones@googlemail.com It should not be fixed at this series. So I'll fixed this warning in another fixed patch. > > > drivers/gpu/drm/mediatek/mtk_drm_drv.c:203:42: warning: unused > > > variable 'mt2701_mmsys_match_data' [-Wunused-const-variable] > > static const struct mtk_mmsys_match_data mt2701_mmsys_match_data = > { > ^ > > > drivers/gpu/drm/mediatek/mtk_drm_drv.c:218:42: warning: unused > > > variable 'mt7623_mmsys_match_data' [-Wunused-const-variable] > > static const struct mtk_mmsys_match_data mt7623_mmsys_match_data = > { > ^ > > > drivers/gpu/drm/mediatek/mtk_drm_drv.c:234:42: warning: unused > > > variable 'mt2712_mmsys_match_data' [-Wunused-const-variable] > > static const struct mtk_mmsys_match_data mt2712_mmsys_match_data = > { > ^ > > > drivers/gpu/drm/mediatek/mtk_drm_drv.c:246:42: warning: unused > > > variable 'mt8167_mmsys_match_data' [-Wunused-const-variable] > > static const struct mtk_mmsys_match_data mt8167_mmsys_match_data = > { > ^ > > > drivers/gpu/drm/mediatek/mtk_drm_drv.c:260:42: warning: unused > > > variable 'mt8173_mmsys_match_data' [-Wunused-const-variable] > > static const struct mtk_mmsys_match_data mt8173_mmsys_match_data = > { > ^ > > > drivers/gpu/drm/mediatek/mtk_drm_drv.c:274:42: warning: unused > > > variable 'mt8183_mmsys_match_data' [-Wunused-const-variable] > > static const struct mtk_mmsys_match_data mt8183_mmsys_match_data = > { > ^ > > > drivers/gpu/drm/mediatek/mtk_drm_drv.c:288:42: warning: unused > > > variable 'mt8192_mmsys_match_data' [-Wunused-const-variable] > > static const struct mtk_mmsys_match_data mt8192_mmsys_match_data = > { > ^ > > > drivers/gpu/drm/mediatek/mtk_drm_drv.c:305:42: warning: unused > > > variable 'mt8195_mmsys_match_data' [-Wunused-const-variable] > > static const struct mtk_mmsys_match_data mt8195_mmsys_match_data = > { Oh, I forgot to replace the driver_data to match_data in mtk_drm_of_ids table. I'll fix them at the next version. Regards, Jason-JH.Lin