From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1756694AbYE0GQZ@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756694AbYE0GQZ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 27 May 2008 02:16:25 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753749AbYE0GQO
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 27 May 2008 02:16:14 -0400
Received: from stinky.trash.net ([213.144.137.162]:43625 "EHLO
	stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752742AbYE0GQN (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 27 May 2008 02:16:13 -0400
Message-ID: <483BA72B.5010207@trash.net>
Date: Tue, 27 May 2008 08:16:11 +0200
From: Patrick McHardy <kaber@trash.net>
User-Agent: Mozilla-Thunderbird 2.0.0.12 (X11/20080405)
MIME-Version: 1.0
To: Dmitry Petukhov <dmgenp@gmail.com>
CC: linux-kernel@vger.kernel.org, Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: possible double call of kfree_skb in net/llc/llc_sap.c
References: <84ee89da0805262300v747c712ayfb60ac8aa790edb7@mail.gmail.com>
In-Reply-To: <84ee89da0805262300v747c712ayfb60ac8aa790edb7@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Dmitry Petukhov wrote:
> In the file  net/llc/llc_sap.c, funcion llc_sap_state_process,
> the call to kfree_skb in the line 227 can proceed even if skb was already freed
> on line 218, or  224, or queued to the user within sock_queue_rcv_skb function.
> Obviously return statement is missing after line 225.
> 
> This problem was found by Alex Shevkov.

Could you send a patch please?