From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758607AbZEFE23 (ORCPT ); Wed, 6 May 2009 00:28:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751660AbZEFE2Q (ORCPT ); Wed, 6 May 2009 00:28:16 -0400 Received: from wf-out-1314.google.com ([209.85.200.169]:4987 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbZEFE2O (ORCPT ); Wed, 6 May 2009 00:28:14 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=V7Kub9DfBPHj1y138IS/5p3i38XpWnbdi0hbyLxzkm+NvaQ3EueRekDhJ1Zaowj0LU x8It/A0/FC/3D4I4YfB18MpLDjU3mdo0Ri5zAFcoQdwUheRtk3wg+RHxBPa4BsovODMt o0VquigUyM9plen/2Fr3lWAB8ZZ40/p3JlTjw= MIME-Version: 1.0 In-Reply-To: <5d5443650905041021n1f709ce1y382440d1285b09ec@mail.gmail.com> References: <1241006627-22811-1-git-send-email-thierry.reding@avionic-design.de> <5d5443650904290623n3712cd7dja653a139cff2cf6d@mail.gmail.com> <483a38b80904291835p51044741p9bd83d33a40031c@mail.gmail.com> <20090504113751.GA22603@avionic-design.de> <5d5443650905040503n501e3b47qc890dc4c71a85b1c@mail.gmail.com> <20090504145700.GA875@avionic-design.de> <5d5443650905041021n1f709ce1y382440d1285b09ec@mail.gmail.com> Date: Wed, 6 May 2009 13:28:14 +0900 Message-ID: <483a38b80905052128s33c39403r996ca35e09eeabc4@mail.gmail.com> Subject: Re: [PATCH] input: Add support for the TSC2003 controller. From: Kwangwoo Lee To: Trilok Soni Cc: Thierry Reding , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, May 5, 2009 at 2:21 AM, Trilok Soni wrote: > Hi Therry, > > On Mon, May 4, 2009 at 8:27 PM, Thierry Reding > wrote: >> * Trilok Soni wrote: >>> Hi Thierry, >>> >>> On Mon, May 4, 2009 at 5:07 PM, Thierry Reding >>> wrote: >>> > * Kwangwoo Lee wrote: >>> >> Hi Thierry and Trilok, >>> >> >>> >> On Wed, Apr 29, 2009 at 10:23 PM, Trilok Soni wrote: >>> >> > Hi Thierry, >>> >> > >>> >> > I have added linux-omap community. How different is this chip from >>> >> > tsc2007. It looks to me that this chip is not much different from >>> >> > tsc2007 (this is just quick look at the driver). If they >>> >> > are similar please consider using i2c_device_id feature in tsc2007 to >>> >> > accommodate this chip. >>> >> >>> >> I agree with the Trilok's opinion. >>> > [snip] >>> > >>> > I only noticed the tsc2007 driver some time ago, when the tsc2003 was already >>> > finished (it's actually pretty old, I just never got around to submitting >>> > it). However I never got the tsc2007 to work on my platform because it uses >>> > sleeping functions inside the timer handler, which results in an oops right >>> > after the first touchscreen interrupt. >>> > >>> > I guess I could try and fix the tsc2007 properly instead of having a second, >>> > pretty similar driver in the tree. >>> > >>> >>> This could be because of improper locking? If you share a crash we can >>> have look at it. >> >> Attached is a patch that fixes things for me. The problem was that the I2C >> transfers were done in interrupt context which fails for the controller I use >> (PXA270). The attached patch uses a struct work_struct to schedule the I2C >> transfers so they are executed in non-interrupt context. >> >> I've tested the patch on a minimal system with tslib and it work fine with >> ts_calibrate and friends. > > Thanks for the patch. It looks good. Let's wait for Kwangwoo Lee to > verify it on his platform. Also please add "tsc2003" entry into > i2c_device_ids so that i2c_board_info can specify the .name as > "tsc2003". I tested the patch in my platform with tslib. And it looks good. Thanks, -- Kwangwoo Lee