From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965295AbdEOTfH (ORCPT <rfc822;w@1wt.eu>);
        Mon, 15 May 2017 15:35:07 -0400
Received: from mout.web.de ([212.227.15.4]:61784 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932677AbdEOTfF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 15 May 2017 15:35:05 -0400
Subject: Re: [PATCH 3/3] coresight: etb10: Improve a size determination in
 etb_alloc_buffer()
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "Suzuki K. Poulose" <suzuki.poulose@arm.com>,
        kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
References: <5d5cd752-f2f2-b511-6b1e-daf5bf1bc522@users.sourceforge.net>
 <b8ed57f7-cdcf-9b35-4fdd-8833db008ff0@users.sourceforge.net>
 <CANLsYkwxkXZ5t5L1_=2e9FLdkwOg7KUT=u2o-KeEfH8QYOfStA@mail.gmail.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <483aafb4-c864-058b-6e61-1189be427d27@users.sourceforge.net>
Date: Mon, 15 May 2017 21:34:33 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <CANLsYkwxkXZ5t5L1_=2e9FLdkwOg7KUT=u2o-KeEfH8QYOfStA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:ZJCUiUlJGM49ckPTDRf7VLv9HgmrqYrkShvf3jApFO5NQd8yt1q
 Dv15XPpKWsa3nYjLr/U+Lx/8lD4MOhAXTxXs9vPMO6ywYTMQHt+VdP01aIjAopyboX3Dr/T
 3hoGKt6FyAXyPQq5A6paxVl5fDUG7omSnaw2M/Ev782F7FWZpuKnSqXqRrwqYFpVTjd0eAX
 AYHxrCuzP50PCACyOHmNw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:CnBRaFXHNYo=:KQITxJnevU+b2z915MsgED
 w4p9eIeVfXDCxwjt8m+skf64FF8ejgDKNkspF11S6e+i6OXPdFNGGet9mlQXtEf4i9egQiXP/
 BtnEmOrLmlkRgGmwicAwwAEqnDdqE3ousBtXsN2TCw9xRz1WaWEO9PApCr54/JbQGAt5NiFdr
 +2Af6nf+4Mjt6O0b/sUwYjExFEQvwevP6Xhjitgt+MzXQU/406PjZ5D2+OH2ztyUeaVIaerDQ
 09uHL/D9poN1eX7lpBTWLgRJgSFId9qM2cqsifO9gEgUV3P+UxouIvWNQf1j5wfkVzDtbt5hN
 FIQLpzSet7l8Vg5J9S4MwBvvAagb2O7vIwXA07JUoHmWqQSHsI4nnYkybzyqvq68VqyZ6mL2D
 fEYqh6XstzeSCznSOXpiR/g5O5fZHb9R/IKXEKjwPV83nnSCkyEQ93DANC+7JFBYHDszrilnv
 bhAm19aEXMkBVBWQ5Nga2LfLevIndbeMhw5mkWQGmdLlZyH0biGLjd7+iPUtPexdVfrGiRWoM
 RQPV01ySRg3KABKNAw2I6lfs/7xH8fAvvjQdhrEYQEiUUbZjZxcUWpIsBS90PZFiB6cHGxVYc
 sS9NQWwPuqfP4kcsQ1EaNoojiJENHo9IFIWt0oXbhIFT9ssFg0QyTodi8EIcAW9fB3Y35+RLD
 BUU+S3+VVjVajQxvXbEEo1fON8BTqWZyL/eZanB8ylZJcPjdk80YYiTwT+D/9V0cOVidbjoS0
 Z2WFTgUT/rZL/wjOpJ4EWZzytvzR20YkvaZTeMKq6kUEtb0iVW+uIUk9u6BrTdXsbiYgskNhc
 bWZYLWh
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> +++ b/drivers/hwtracing/coresight/coresight-etb10.c
>> @@ -278,8 +278,7 @@ static void *etb_alloc_buffer(struct coresight_device *csdev, int cpu,
>>         if (cpu == -1)
>>                 cpu = smp_processor_id();
>>         node = cpu_to_node(cpu);
>> -
>> -       buf = kzalloc_node(sizeof(struct cs_buffers), GFP_KERNEL, node);
>> +       buf = kzalloc_node(sizeof(*buf), GFP_KERNEL, node);
> 
> I'm fine with this change but if it's going to happen, it has to be in
> all the coresight drivers and not just this one - please respin with
> all instances fixed.  One patch per driver would be much appreciated.

Do you imagine that any more modules are affected in a similar way
for this software area?

How do you think about other update suggestions from my selection
which are waiting for a corresponding review?

Regards,
Markus