From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031948AbdAJMMC (ORCPT ); Tue, 10 Jan 2017 07:12:02 -0500 Received: from fllnx210.ext.ti.com ([198.47.19.17]:41792 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031537AbdAJML7 (ORCPT ); Tue, 10 Jan 2017 07:11:59 -0500 Subject: Re: [PATCH v5 0/6] inherit dma configuration from parent dev To: Greg KH References: <1479383028-27701-1-git-send-email-sriram.dash@nxp.com> <6ac3f225-674d-2329-a79b-e4f0652cc03d@ti.com> <20170105171605.GA21589@kroah.com> CC: Sriram Dash , , , , Mathias Nyman , , , , , Grygorii Strashko From: Roger Quadros Message-ID: <483d2264-b45a-4142-6dc4-e96637d452fd@ti.com> Date: Tue, 10 Jan 2017 14:11:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170105171605.GA21589@kroah.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/01/17 19:16, Greg KH wrote: > On Thu, Jan 05, 2017 at 05:21:09PM +0200, Roger Quadros wrote: >> Hi, >> >> On 17/11/16 13:43, Sriram Dash wrote: >>> For xhci-hcd platform device, all the DMA parameters are not >>> configured properly, notably dma ops for dwc3 devices. >>> >>> The idea here is that you pass in the parent of_node along >>> with the child device pointer, so it would behave exactly >>> like the parent already does. The difference is that it also >>> handles all the other attributes besides the mask. >>> >>> Arnd Bergmann (6): >>> usb: separate out sysdev pointer from usb_bus >>> usb: chipidea: use bus->sysdev for DMA configuration >>> usb: ehci: fsl: use bus->sysdev for DMA configuration >>> usb: xhci: use bus->sysdev for DMA configuration >>> usb: dwc3: use bus->sysdev for DMA configuration >>> usb: dwc3: Do not set dma coherent mask >> >> Only the dwc3 patches have been picked up for v4.10 and the rest are still missing. >> Any plans to pick them in the rc cycle? >> >> DMA configuration is still broken for XHCI on v4.10 and -next. > > It's always been broken, so it's not a big deal for 4.10 :) > OK. But I do see the following warning on xhci probe on TI platforms that use dwc3 IP. This is new in v4.10. [ 11.664835] ------------[ cut here ]------------ [ 11.669693] WARNING: CPU: 1 PID: 534 at drivers/usb/host/xhci-plat.c:168 xhci_plat_probe+0x180/0x450 [xhci_plat_hcd] [ 11.680765] Modules linked in: xhci_plat_hcd(+) xhci_hcd usbcore evdev dwc3 snd_soc_simple_card snd_soc_tlv320aic3x snd_soc_simple_card_utils udc_core m25p80 snd_soc_davinci_mcasp usb_common spi_nor snd_soc_e [ 11.726078] CPU: 1 PID: 534 Comm: modprobe Tainted: G W 4.10.0-rc3 #1075 [ 11.734293] Hardware name: Generic DRA74X (Flattened Device Tree) [ 11.740695] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [ 11.748829] [] (show_stack) from [] (dump_stack+0xac/0xe0) [ 11.756413] [] (dump_stack) from [] (__warn+0xd8/0x104) [ 11.763722] [] (__warn) from [] (warn_slowpath_null+0x20/0x28) [ 11.771675] [] (warn_slowpath_null) from [] (xhci_plat_probe+0x180/0x450 [xhci_plat_hcd]) [ 11.782110] [] (xhci_plat_probe [xhci_plat_hcd]) from [] (platform_drv_probe+0x4c/0xb0) [ 11.792338] [] (platform_drv_probe) from [] (driver_probe_device+0x200/0x2d4) [ 11.801655] [] (driver_probe_device) from [] (__driver_attach+0xc0/0xc4) [ 11.810518] [] (__driver_attach) from [] (bus_for_each_dev+0x6c/0xa0) [ 11.819095] [] (bus_for_each_dev) from [] (bus_add_driver+0x18c/0x214) [ 11.827767] [] (bus_add_driver) from [] (driver_register+0x78/0xf8) [ 11.836167] [] (driver_register) from [] (do_one_initcall+0x3c/0x174) [ 11.844751] [] (do_one_initcall) from [] (do_init_module+0x5c/0x1d0) [ 11.853247] [] (do_init_module) from [] (load_module+0x1d48/0x23a8) [ 11.861649] [] (load_module) from [] (SyS_init_module+0x150/0x174) [ 11.869961] [] (SyS_init_module) from [] (ret_fast_syscall+0x0/0x1c) [ 11.878494] ---[ end trace a0ca4c6c0c9a9ee9 ]--- [ 11.883400] xhci-hcd xhci-hcd.0.auto: xHCI Host Controller cheers, -roger