From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48C7F3148B6 for ; Tue, 9 Sep 2025 10:02:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757412148; cv=none; b=BoKOBH59N/Xk7zYSck4ggCgp35iMMtVpwyS02/TbRMs0UEb3zG23dg8bgRlm6OQTe6nOyYvHPQyZr1fqa8ak/9OC6rCz+0+k2osLLsbKXWk7qu5kgr0xkfclaxgPcNtlhRy1hrTheGCU+fb3i1idk5xrgY9iEfLs0M88bUiV9wc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757412148; c=relaxed/simple; bh=iQ5gERobvATb314ro5gdhE+DkIWkSDFz9Z8hAAya7KA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=loXRFiBcwqQRzPG6bLjahzxsMddpbfP+Tw543xHbcdqCJu6sdwWUCkXbKkaXDX0vanjrZrV1sWKvp/qow7UNw7Z+QPUbY1Z+lVpR3AOcbUWJK3Wb3Odp7tKmao47ujlt7Xd436r6RIaQS5RHyjzq8SEsywzdD5rWMlpWQAN+uR0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KnqQ6qAi; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KnqQ6qAi" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5899LUQi029184 for ; Tue, 9 Sep 2025 10:02:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4HaulBQ7AYoFu5zw4WFGYJoR+Ifng1FxEuEOGIbmKB8=; b=KnqQ6qAirfLwNjnQ FWYep/qK09brm/KftOca+OO1UjSL+rwsIoDXjs1SPz6Rw/AJx1GfiJ27yKV2Pyhg ucgkr2rcjVBp8NujvnglVswlEhl3VZUt1BpNrpguSPDsUUaXDpqwlXzhWDuR61PH d5l3ml2/gDCStL8Pw3Y6mINgtk+EjRCfQfC1/++LQUzML4OO5jxOjVtPIkJQWwR9 9q8um6oKIt0+eFosstJxvdocSXztz+QDIK9z1BlgOv116NQmlJVJQrZ9SKaqqFun jwkU1sRlLXQeGDmAmATrhU1Tk30F/bp1F4mLmqLhj9mQkTGmtrl7kf3RjBun7bVk s1EGRQ== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 490db8fu62-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 09 Sep 2025 10:02:25 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-b4d3ab49a66so9006215a12.3 for ; Tue, 09 Sep 2025 03:02:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757412144; x=1758016944; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4HaulBQ7AYoFu5zw4WFGYJoR+Ifng1FxEuEOGIbmKB8=; b=QbTW3D123pYQKfCd3V8IgH7MhvjI4SMbq5sU93lKh9bdOQTB7dRZRRCIqZHlzybs6F OgwRMIJ+l90Swx5KC1A4RsmgaE2vkTK8zw8eF6F9fE64xm7oPZ1OIYBGhVUxHuLqUeFM JDQS3XKPfey9cgk09pNAuAx5NQOcXJdFlZUFMTVpM1Fimq5cfb4zQNy+5ssL3MAk3MBy NcRmvmeT9egoK5JsnD2GmcsVBgD1h5BoSDbuaVLRiuWDViq+eTi3kl4QsZ4DK0Bt7Z2/ gYD+PW691WbeFxK2iSwWXbgmQnvHl6HIax2IavH2pH+RhbpZHEBWw3g+6sTwB6wX/iJP Q0aA== X-Forwarded-Encrypted: i=1; AJvYcCWTMjMJ8lgyJgS/3Q1wJRw62i2XF3VGQ9jGjUQCrPy0hTqAUP+HhITbTD80CH/soU0BwZi3gTtpBPY3sVA=@vger.kernel.org X-Gm-Message-State: AOJu0YzlpXjLjCW9aKMjAQ2p31brPYWe9EfqtziwEMsUohQSuRzOQzYf mfIfTpfq/z6VAgAIrBc1XUmBC5IHSMnqHWlTLSoVjyfFaIKamtkPLGkmH1fOf+t4GTMwK5mXZ7h lW5ZVJkPREUpjpgIrPnAoB19/wesGsuB3mM06K85utRmWNrb1OIlpY/CtkeDFf3THKHI= X-Gm-Gg: ASbGncv2qUtdB3r3k6ILPdjIqEjjQLxdxmZdcX6kckwY4s95xFJ7T8LzBQYDJ6/Mtml ro8PcWoRoI538bOfUGMvfFJXt/UYNPwS5/q/mdOcXNpNwf8SjH3KnAuosEuXAHcu9a0duyh/x1J NREAwylfhoJ3mmedg7XtQRdvmmgSfAK2FGXTXawL512Pzstvmzgp8o2c0URy/5sdE4oj9lsyN5C /64WWvHQG2Fsuknk6P3N6gVsp/Qs+FqV4uL50moISpaAQmI3NppL4B6DM51qD07mxGA7tgKpZZP QaPmHokFYZhqDxkiQ/eVSEDH37bQz+THuOXUr6t/Rarr2HGMMgwfmciJ1WPTO/c4yQseDfSm2w1 mEPxr/kGWBNiMP5eK92PtJse/5ryyvEZDTQ== X-Received: by 2002:a17:902:f60b:b0:24c:9a51:9a4b with SMTP id d9443c01a7336-251703958bdmr150722605ad.21.1757412143556; Tue, 09 Sep 2025 03:02:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGetpndXROcKB2fp2rRqcvrm+wqc4vDETNgwz1xtv8hDlxdy1e7FS/7JbWqSHVAsyjPVhVOeg== X-Received: by 2002:a17:902:f60b:b0:24c:9a51:9a4b with SMTP id d9443c01a7336-251703958bdmr150721735ad.21.1757412142865; Tue, 09 Sep 2025 03:02:22 -0700 (PDT) Received: from [10.133.33.119] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-24cb28c3110sm151780825ad.120.2025.09.09.03.02.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Sep 2025 03:02:22 -0700 (PDT) Message-ID: <483e3380-0e88-4a95-950b-0a533bf7ce17@oss.qualcomm.com> Date: Tue, 9 Sep 2025 18:02:16 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 4/4] arm64: dts: qcom: Add base HAMOA-IOT-EVK board To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250909-hamoa_initial-v10-0-ec10057ffcd2@oss.qualcomm.com> <20250909-hamoa_initial-v10-4-ec10057ffcd2@oss.qualcomm.com> Content-Language: en-US From: Yijie Yang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTA2MDAzMSBTYWx0ZWRfX8ud1q9akVfN3 /kLJ9YQgUZklcjvhrKyYNqFWNyF5MSkligLUrRXTQ0EIaihH4CTQAgjUPorYnJgR5c74SiWJU5A 6LYvmfwXkHDfxcFyAQLOa7kh6dV6Ui710NgPXsHqUrJs9PaohpvqVkB254i9WbtKQtNMpKEh0eO UOGdGa1vRR69d5/i/7yMP4GgknmysMH6LcraiiH2bSWk2lNK7QUwaAgsIJUY5TKTQWqnOg38/2s bLy/zkkwsFHbHznIetwhIu5Xlza/j9iARMn1PTFKR1eFFR/4G06Q2DDXV8fDVzthDPMA0D+pDCW IQjhCcXvcV0NiC1r8dzKdI1SsZECNILQdfXHDUKbK6VZq8TwP2SmkM6nJlwkE1PIXsT8fShJ4Xb jB7imE5J X-Proofpoint-ORIG-GUID: FY7kjkfB0kiC2yJkdqflW8-F6f0Dfkhj X-Proofpoint-GUID: FY7kjkfB0kiC2yJkdqflW8-F6f0Dfkhj X-Authority-Analysis: v=2.4 cv=VIDdn8PX c=1 sm=1 tr=0 ts=68bffb31 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=COk6AnOGAAAA:8 a=sn0vIxX-2wHjl4zpZ4MA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 a=cvBusfyB2V15izCimMoJ:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-08_06,2025-09-08_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 spamscore=0 suspectscore=0 bulkscore=0 phishscore=0 adultscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509060031 On 2025-09-09 16:31, Konrad Dybcio wrote: > On 9/9/25 5:56 AM, Yijie Yang wrote: >> The HAMOA-IOT-EVK is an evaluation platform for IoT products, composed of >> the Hamoa IoT SoM and a carrier board. Together, they form a complete >> embedded system capable of booting to UART. >> >> Make the following peripherals on the carrier board enabled: >> - UART >> - On-board regulators >> - USB Type-C mux >> - Pinctrl >> - Embedded USB (EUSB) repeaters >> - NVMe >> - pmic-glink >> - USB DisplayPorts >> - Bluetooth >> - WLAN >> - Audio >> >> Written in collaboration with Quill Qi (Audio) , >> Jie Zhang (Graphics) , Shuai Zhang (Bluetooth) >> , Yingying Tang (WLAN) , >> and Yongxing Mou (USB DisplayPorts) . >> >> Signed-off-by: Yijie Yang >> --- > > [...] > >> + sound { >> + compatible = "qcom,x1e80100-sndcard"; >> + model = "X1E80100-EVK"; >> + audio-routing = "WooferLeft IN", >> + "WSA WSA_SPK1 OUT", >> + "TweeterLeft IN", >> + "WSA WSA_SPK2 OUT", >> + "WooferRight IN", >> + "WSA2 WSA_SPK2 OUT", >> + "TweeterRight IN", >> + "WSA2 WSA_SPK2 OUT", >> + "IN1_HPHL", >> + "HPHL_OUT", >> + "IN2_HPHR", >> + "HPHR_OUT", >> + "AMIC2", >> + "MIC BIAS2", >> + "VA DMIC0", >> + "MIC BIAS3", >> + "VA DMIC1", >> + "MIC BIAS3", >> + "VA DMIC2", >> + "MIC BIAS1", >> + "VA DMIC3", >> + "MIC BIAS1", >> + "VA DMIC0", >> + "VA MIC BIAS3", >> + "VA DMIC1", >> + "VA MIC BIAS3", >> + "VA DMIC2", >> + "VA MIC BIAS1", >> + "VA DMIC3", >> + "VA MIC BIAS1", >> + "TX SWR_INPUT1", >> + "ADC2_OUTPUT"; > > It's good to write these entries in pairs, as that's what they > correspond to. > > Please also take a look at this commit: > b49e37de8e70 ("arm64: dts: qcom: x1e80100-crd: Drop duplicate DMIC supplies") Will update. > > [...] > >> +&i2c5 { >> + clock-frequency = <400000>; >> + status = "okay"; > > A '\n' before status is customary Will update. > > [...] > >> +&usb_mp_hsphy0 { >> + phys = <&eusb6_repeater>; >> +}; >> + >> +&usb_mp_hsphy1 { >> + phys = <&eusb3_repeater>; >> +}; > > See: > > https://lore.kernel.org/linux-arm-msm/20250819-x1e80100-fix-usb-mp-repeaters-v1-4-0f8c186458d3@linaro.org/ > Great reminder! I'll take care of it. > Konrad -- Best Regards, Yijie