From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B681DC433E2 for ; Thu, 17 Sep 2020 00:35:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68DD5206A4 for ; Thu, 17 Sep 2020 00:35:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="Q/uj+ryQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726157AbgIQAf4 (ORCPT ); Wed, 16 Sep 2020 20:35:56 -0400 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:3924 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725858AbgIQAfx (ORCPT ); Wed, 16 Sep 2020 20:35:53 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 16 Sep 2020 17:35:39 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Wed, 16 Sep 2020 17:35:52 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Wed, 16 Sep 2020 17:35:52 -0700 Received: from rcampbell-dev.nvidia.com (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 17 Sep 2020 00:35:49 +0000 Subject: Re: [PATCH] mm: remove extra ZONE_DEVICE struct page refcount To: Christoph Hellwig , Dan Williams CC: Linux MM , , , Linux Kernel Mailing List , Ira Weiny , "Matthew Wilcox" , Jerome Glisse , "John Hubbard" , Alistair Popple , "Jason Gunthorpe" , Bharata B Rao , Zi Yan , "Kirill A . Shutemov" , Yang Shi , Paul Mackerras , Ben Skeggs , Andrew Morton References: <20200914224509.17699-1-rcampbell@nvidia.com> <20200916061054.GC7321@lst.de> X-Nvconfidentiality: public From: Ralph Campbell Message-ID: <4842558d-9626-0452-6398-c2fe39a9a31c@nvidia.com> Date: Wed, 16 Sep 2020 17:35:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200916061054.GC7321@lst.de> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1600302939; bh=8LDzccoActo8nWBlttLgmhuoOW1Z2c2MD7demjEypqQ=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=Q/uj+ryQtb/eBmR3IpGzH7gC57BnghlEPBnv1cfvPBKIfxMtly6SFT3dGaW7ig7v7 IqeBEul8UUEhPQWsnDmUGbW5BOBMEwHoFyICyTqId2jjJN+DWzVTtT8r7U9JWuI3ty F/SQQ5yVqGc/dogmTjyTpLXc03CLbAeKQ09g6JU8uxdWledt63qLshfHBS1d0Ml6WU K5/fiDprqbnotHdK0rsU8Gb+3Vl7Mz8C0krvlL4Ho9I3ktE1WwCw75QLUof3DXbClB KZXQ7DGc/wOxKQ62l7DYgJrhRS9BOWyBN5AG8Xic+kGTxp4DZvSYeHVsLZxKc+yfw3 AoiTmL0CKD69g== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/15/20 11:10 PM, Christoph Hellwig wrote: > On Mon, Sep 14, 2020 at 04:10:38PM -0700, Dan Williams wrote: >> You also need to fix up ext4_break_layouts() and >> xfs_break_dax_layouts() to expect ->_refcount is 0 instead of 1. This >> also needs some fstests exposure. > > While we're at it, can we add a wait_fsdax_unref helper macro that hides > the _refcount access from the file systems? Sure. I'll add a separate patch for it in v2.