From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84ECAC2BA19 for ; Thu, 16 Apr 2020 02:01:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6739020725 for ; Thu, 16 Apr 2020 02:01:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731176AbgDPCBU (ORCPT ); Wed, 15 Apr 2020 22:01:20 -0400 Received: from out30-54.freemail.mail.aliyun.com ([115.124.30.54]:60307 "EHLO out30-54.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729707AbgDPCAw (ORCPT ); Wed, 15 Apr 2020 22:00:52 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R851e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07488;MF=tianjia.zhang@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0Tveg8zr_1587002446; Received: from 30.27.118.45(mailfrom:tianjia.zhang@linux.alibaba.com fp:SMTPD_---0Tveg8zr_1587002446) by smtp.aliyun-inc.com(127.0.0.1); Thu, 16 Apr 2020 10:00:47 +0800 Subject: Re: [PATCH] KVM: Optimize kvm_arch_vcpu_ioctl_run function To: Paolo Bonzini , Vitaly Kuznetsov Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, maz@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com References: <20200413034523.110548-1-tianjia.zhang@linux.alibaba.com> <875ze2ywhy.fsf@vitty.brq.redhat.com> <87a73dxgk6.fsf@vitty.brq.redhat.com> <9e122372-249d-3d93-99ed-a670fff33936@redhat.com> From: Tianjia Zhang Message-ID: <4843f690-7071-aa4f-cc9d-d9cc2321e669@linux.alibaba.com> Date: Thu, 16 Apr 2020 10:00:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <9e122372-249d-3d93-99ed-a670fff33936@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/4/15 22:53, Paolo Bonzini wrote: > On 15/04/20 11:07, Vitaly Kuznetsov wrote: >> In case this is no longer needed I'd suggest we drop 'kvm_run' parameter >> and extract it from 'struct kvm_vcpu' when needed. This looks like a >> natural add-on to your cleanup patch. > > I agree, though I think it should be _instead_ of Tianjia's patch rather > than on top. > > Paolo > Thank you very much for the comments of Vitaly and Paolo, I will make a v2 patch. Thanks and best, Tianjia