From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6239156256 for ; Mon, 15 Apr 2024 19:50:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713210644; cv=none; b=EOJ/NRi5COQ7b4hpyJr8b88I5bC771lehDFku+Jv7evlehVVXW2rVrJPoFa8qE4ySK2UGYozHrAA9VqB65DAyLb024G/wFfqyfJ1pASn1P8RkjWn/PzFwQ3CUxvWc86Ez9jFfJTRePf6CVoJWhtp9pptStI0JTznF2cp9jjumd4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713210644; c=relaxed/simple; bh=mu9CDbddqj1yG3DTgcUzw0htZFsVhwUKyY1dxFCnFC4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mhJfUeFVH74/0TjtmkWtBLCa5FEHD+Opwuhn0wxdB/nhMScIJmY5o16HHsDwJ6awzgnROk/15fNiMlqhOEzXvAxyzMh4RJ6EKbgpe9v6CtQmjHoJSXkK8ni2KsKR3bQc8KA5ZBLX3dEARSrCBieyq1WTARCmJCBxs1khbUR+n/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Nx+vexuJ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Nx+vexuJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713210641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v1GrzdHBx1Ad9AXyvk71PE5SXmynmZXwlPU0KzZCj/s=; b=Nx+vexuJRr5+DNP9DlzkHMBt2y6fx/Dmrh0AfcmhjbeRPrzp2sSoFojlVVIwrQbhWfLC+W q2AmVAb0EXX9aG2rC1rFTGVvXL8kJGDvjEHorwaEqkik77h33EXeseBdvYRUDS+w0p5Af7 dGSU/Lxg/zdfWa5OMLXzg6nslNdpzjg= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-3-ZV5M7WZ0N9626baCVlpojA-1; Mon, 15 Apr 2024 15:50:39 -0400 X-MC-Unique: ZV5M7WZ0N9626baCVlpojA-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a5217f85620so239252866b.2 for ; Mon, 15 Apr 2024 12:50:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713210638; x=1713815438; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v1GrzdHBx1Ad9AXyvk71PE5SXmynmZXwlPU0KzZCj/s=; b=PXXbgZBe/BbjnhuufPT2vGqABA8mQ5tODb2fCYZDIgLay7e0+uxOoQ2jFw0qm/S/k/ wJtsi73Ft0YJoIHpJbm90YziewZNIKTs7uHVVoVa4ybJmU7i/ilvZb1wBeEY+vTpRpX+ tpXAZRAwXsgqi3giaffeSdjp84Ra/meSSxtZgh4fuJId8YSVq0x8R+nWzs9UR65/nu9b TN3LqZ0LOedmcw7sZO6t2JtitfrQdMZUchKBpIf326Snx5OOs5NEyiGQq1bssvJXjjX9 ctghKz7p7uiPwVfPLOiwo9syEcu6M4LNqYI4Spy9vavNLotzlBuwDa3QxMNBSsIim4Nk IF4g== X-Forwarded-Encrypted: i=1; AJvYcCW35MK3n/w+cVuHM7c6lJoSN4Q6rBvPfPBUBDkao4lPJTWaBQGKN2luJbTcSwUQYHut2Xu4+adWNPgQziFnAUGIbj35KoI31LasV+sY X-Gm-Message-State: AOJu0YzjuvI2dduRxofV0oafPCG7mXOsNsHVMpwE6GDyI24L8bwVQ0Ln pTWY6m9CTqEeIBMff6A7EZ/vkEu1C/XivE3tc28wFRoD+hmZOUi6IRTTFmtfkWpMEZzT/KbDWxZ 9qxTHPzlDwEB8pfYL3AmszmFJX7p5TpoS2JjehukhNGOnKSukm8p6Gvh0MejJzg== X-Received: by 2002:a17:907:31c9:b0:a52:4fc1:ea90 with SMTP id xf9-20020a17090731c900b00a524fc1ea90mr5109451ejb.62.1713210638733; Mon, 15 Apr 2024 12:50:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHkw2/6umyRmgjkAwH2zmoEmiOVCpq7HOf5cUaBKrczviiqH4WXk5gSC+/1C1FS72qcWzmrbw== X-Received: by 2002:a17:907:31c9:b0:a52:4fc1:ea90 with SMTP id xf9-20020a17090731c900b00a524fc1ea90mr5109443ejb.62.1713210638426; Mon, 15 Apr 2024 12:50:38 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id bv21-20020a170906b1d500b00a520b294d9dsm5850643ejb.150.2024.04.15.12.50.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Apr 2024 12:50:38 -0700 (PDT) Message-ID: <484638e2-1565-454b-97f8-4fcc6514a69c@redhat.com> Date: Mon, 15 Apr 2024 21:50:37 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] Input: Add trackpoint doubletap and system debug info keycodes To: Dmitry Torokhov , Mark Pearson Cc: Peter Hutterer , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Henrique de Moraes Holschuh , ibm-acpi-devel@lists.sourceforge.net, "platform-driver-x86@vger.kernel.org" , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Nitin Joshi1 , Vishnu Sankar References: <20240324210817.192033-1-mpearson-lenovo@squebb.ca> <20240324210817.192033-2-mpearson-lenovo@squebb.ca> <92ee5cb2-565e-413c-b968-81393a9211c4@app.fastmail.com> <91593303-4a6a-49c9-87a0-bb6f72f512a1@app.fastmail.com> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 4/15/24 9:40 PM, Dmitry Torokhov wrote: > On Wed, Apr 10, 2024 at 10:48:10PM -0400, Mark Pearson wrote: >> >> I have a stronger preference to keep the KEY_DOUBLECLICK - that one seems less controversial as a genuine new input event. > > Please see my response to Peter's letter. I think it very much depends > on how it will be used (associated with the pointer or standalone as it > is now). > > For standalone application, recalling your statement that on Win you > have this gesture invoke configuration utility I would argue for > KEY_CONFIG for it. KEY_CONFIG is already generated by Fn + F# on some ThinkPads to launch the GNOME/KDE control center/panel and I believe that at least GNOME comes with a default binding to map KEY_CONFIG to the control-center. So IMHO re-using KEY_CONFIG for the doubletap trackpoint thing is not a good idea. But as mentioned elsewhere in the thread everyone seems to be ok with using KEY_VENDOR for this ? Regards, Hans