Re: [PATCH v1 7/8] ARM: dts: aspeed: system1: Mark GPIO line high/low

[Ninad Palsule <ninad@linux.ibm.com>]

Hello Krzysztof,

Thanks for the review. Sorry for the delay as I was on vacation.

On 12/13/24 09:49, Krzysztof Kozlowski wrote:
> On 13/12/2024 15:50, Ninad Palsule wrote:
>> From: NINAD PALSULE <ninadpalsule@us.ibm.com>
>>
>> - Mark following GPIO lines as input high:
>>    - GPIOL4 (reset PCH registers)
>>    - GPIOL5 (reset portition of intel ME)
>> - Mark isolate errors from cpu1 gpio (GPIOO6) as active low output.
>> - The fan controller reset line should be active high.
>>
>> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
>> ---
>>   .../dts/aspeed/aspeed-bmc-ibm-system1.dts     | 28 +++++++++++++++++++
>>   1 file changed, 28 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
>> index ca2d4a292687..be0cd6152c61 100644
>> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
>> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
>> @@ -383,6 +383,34 @@ &gpio0 {
>>   	/*X0-X7*/	"fpga-pgood","power-chassis-good","pch-pgood","","","","","",
>>   	/*Y0-Y7*/	"","","","","","","","",
>>   	/*Z0-Z7*/	"","","","","","","","";
>> +
>> +	rtc_reset {
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
> Maybe you need to update your dtschema and yamllint. Don't rely on
> distro packages for dtschema and be sure you are using the latest
> released dtschema.

Changed name as per the requirement hog-0...3

Regards,

Ninad

>
> Best regards,
> Krzysztof