From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF12C3DA7A for ; Thu, 5 Jan 2023 20:34:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235236AbjAEUeM (ORCPT ); Thu, 5 Jan 2023 15:34:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232222AbjAEUeI (ORCPT ); Thu, 5 Jan 2023 15:34:08 -0500 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E2B763D0A for ; Thu, 5 Jan 2023 12:34:07 -0800 (PST) Received: by mail-pf1-x435.google.com with SMTP id e21so16641259pfl.1 for ; Thu, 05 Jan 2023 12:34:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bRrUFCrJ0axzfdpreZeRdI/QQfQaUE17V9V5mc2K1ns=; b=H/yHivCnjpaZvktvjt0pMyr68l36MjJiIDmL3HoKwpZElMwxfhpNjGV91ULP0Tig9j YUu1MytW73O1WRCeyF/CwBTgR3Lr/qxCOc5HbzfbFH4b/bVl4luvl6OxC162dN/rP8Tx EUw2FvR70EYQ/x+QZnys1V5nYBRiDC27fUEviBOuSgfmGcZ5wDahHp8wHMGHKEcIIUJe FZ5szjgCcADY6q9Jbs/pKIU7rSoXXDpcR5yRNVwVza13yeIMsA3fMj4Cu9v2uv6oQGGC wKae0KUUrscdjJhrc7RQ2Rh7C57RyBRsD05LNSHoHyBE3f+cPABJ+FZg3Xj8YddmECSw I8uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bRrUFCrJ0axzfdpreZeRdI/QQfQaUE17V9V5mc2K1ns=; b=VmUpTZhGRBLP6zvP52ZpKquM5SDjwQMypkyQOxEM4dEXFvTpAkKRl2xOJ/0y8/DlyW oD1lG6WF9Pb4qGLiwGr+TCmb3X8XCzxf+WyR+f4IUhSu3Wr1+sZVRQo/lGzJmuS9VqaI evxnLv1ZGtr2+aMCCxNuOhhGsLotuNTOFdIqiRektCfr5rgqzuuAooo8oilRCEQf6X+t 2AFEoYWmUJHrjqOvWjwVBs7BXkvWZ1Swg5yIDatYWKKG/HB1PBDDNIBTZg+u3qp382K4 W2xpT0iNz08RTifqJxphlSVHyHlJuq40LF3eHqgxLGCa+IiOraIkClcxn3wNMH8JfQK1 VrQg== X-Gm-Message-State: AFqh2kpvhYY0QY3Ek1N40j9bPZ4IcJEBaRKrlX7/7AEozZilVh4xX/+o sxLppWp7GYdFv31OsxRtGQhTI/TuWHhwiSJJ X-Google-Smtp-Source: AMrXdXvJrehsNWGSIB4eCqNf9jo0tej0NF9fj1KpeeVPCJ4V6q5OUmufmgzHcJRz2bWIrXSLbLvfdQ== X-Received: by 2002:a62:ea01:0:b0:582:bbc7:c61e with SMTP id t1-20020a62ea01000000b00582bbc7c61emr9050199pfh.11.1672950846661; Thu, 05 Jan 2023 12:34:06 -0800 (PST) Received: from smtpclient.apple (c-24-6-216-183.hsd1.ca.comcast.net. [24.6.216.183]) by smtp.gmail.com with ESMTPSA id g23-20020aa796b7000000b005811082f134sm20408947pfk.158.2023.01.05.12.34.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jan 2023 12:34:06 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: [PATCH] x86/lib: Do not use local symbols with SYM_CODE_START_LOCAL() From: Nadav Amit In-Reply-To: <20221122071547.165296-1-namit@vmware.com> Date: Thu, 5 Jan 2023 12:33:54 -0800 Cc: Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <48498199-175D-467B-942B-9F8A923B8930@gmail.com> References: <20221122071547.165296-1-namit@vmware.com> To: Thomas Gleixner X-Mailer: Apple Mail (2.3731.300.101.1.3) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Nov 21, 2022, at 11:15 PM, Nadav Amit wrote: > > From: Nadav Amit > > When SYM_CODE_START_LOCAL() is used, the symbols are local but should be > saved to the object. In contrast, using ".L" label prefix causes the > symbols not to be saved in the object. > > Since it is preferable to be able to map instruction pointers back to > symbols, the local symbol should be saved in the object. Therefore, when > SYM_CODE_START_LOCAL() is used, the ".L" label prefix should not be > used. > > Two symbols, however, have both SYM_CODE_START_LOCAL() and ".L" prefix: > .Lbad_put_user_clac and .Lcopy_user_handle_tail. Remove the ".L" prefix > from them. > > No functional change, other then emitting these symbols into the object, > is intended. > > Signed-off-by: Nadav Amit Ping.