From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 355C2C3F2D1 for ; Mon, 2 Mar 2020 14:24:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 05C66214DB for ; Mon, 2 Mar 2020 14:24:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="MzTmGTJF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727314AbgCBOYN (ORCPT ); Mon, 2 Mar 2020 09:24:13 -0500 Received: from mail-io1-f67.google.com ([209.85.166.67]:44067 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726988AbgCBOYN (ORCPT ); Mon, 2 Mar 2020 09:24:13 -0500 Received: by mail-io1-f67.google.com with SMTP id u17so6720562iog.11 for ; Mon, 02 Mar 2020 06:24:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=PACo5Ylnf7NlwWUXpbNnwLxP6xNyl17woukMg4Z+f5U=; b=MzTmGTJFSVEPetBZXXYsZGKRt+4IFVStmmrD9x/wRyuOE2ZmuyHJnQac3jqiptf8v4 4MVEO0hQPHSPvnmAyKvYv46Yde8Rf6M8jmM0TFzH6yL9PizgUNgFNA6EolvVdn6cEQ0G EWr8HWk0kGHCc9vTcfAjVYmv9LjsXv0IUW4eXh4AFxon6xQ/U/y6dgOczszAYS0BXfj1 DGeiLl6Il4eOoXzNPII6dafmGD1LR0x8XKQ0jwFgvMzkhqkyeg2DfpsKjQxztSn64GWv d17lD6Zt0or1HK1ZLhF0nB5s4XIijwqKXCJdssH5DgavcdwDhJBMIfDUzbjgj3Qxo/AN OeKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PACo5Ylnf7NlwWUXpbNnwLxP6xNyl17woukMg4Z+f5U=; b=i1zDMTVCuyadbDsrAW7MXLFXHIhvEgZCoDP0KJ5BBEYTqpOk+RA9nVaLZSabqfrLPv 7WL8nGcU8k0Z4UWEYACZce1/wzNGG117/bd3uwc/HXD0dHaJys4Z+sH0PbN7bDBfDD3e RWzUttzc5PC8RvZdZW6qIFL1MyhZYOiHu6gnrumltW37KwdJPOw9eSblIZ6mxuka2y4N KqjCYfISRX4x6oTN5jNMjiIDEGMcSDUSEASaDEeK0IPan79fLUWMl8gYcvv+9Il9jbEn WnrgjKXXssFVlavP+hyT4IU+t2Ulgb5Eh89nRdSt0sxx4LrVAvmljn9lbie2DpPP9/Qy xVeA== X-Gm-Message-State: APjAAAVFcY6+nWfUJkkrJwTabJbY8ySPEiNAzjwrfmC9UF+yyKR8anPd VWSXM7TdJK6SsGy/41BDjqeESOFQP3E= X-Google-Smtp-Source: APXvYqzWEKcDRLKAtSq/cOl2Ho433UN3L0r3XjDf1zrgDpjTIVooJ8tuckgIZyV5fcqrtBkRru6MbQ== X-Received: by 2002:a02:81cc:: with SMTP id r12mr13605862jag.93.1583159051231; Mon, 02 Mar 2020 06:24:11 -0800 (PST) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id d7sm888275iog.28.2020.03.02.06.24.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2020 06:24:10 -0800 (PST) Subject: Re: [PATCH 2/9] io-wq: fix IO_WQ_WORK_NO_CANCEL cancellation To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: <909fe09940628654554531ea5fd2fc04b7002ed8.1583078091.git.asml.silence@gmail.com> From: Jens Axboe Message-ID: <484ff585-85eb-d42f-4a9b-b0a57112b294@kernel.dk> Date: Mon, 2 Mar 2020 07:24:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <909fe09940628654554531ea5fd2fc04b7002ed8.1583078091.git.asml.silence@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/1/20 9:18 AM, Pavel Begunkov wrote: > To cancel a work, io-wq sets IO_WQ_WORK_CANCEL and executes the > callback. However, IO_WQ_WORK_NO_CANCEL works will just execute and may > return next work, which will be ignored and lost. Applied this one for 5.6. -- Jens Axboe