From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Moon Yeounsu <yyyynoom@gmail.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] net: ethernet: use ip_hdrlen() instead of bit shift
Date: Wed, 7 Aug 2024 14:28:06 +0200 [thread overview]
Message-ID: <4850b81e-d426-4abd-87f8-2712cd0b5de4@wanadoo.fr> (raw)
In-Reply-To: <20240807100721.101498-1-yyyynoom@gmail.com>
Le 07/08/2024 à 12:07, Moon Yeounsu a écrit :
> `ip_hdr(skb)->ihl << 2` is the same as `ip_hdrlen(skb)`
> Therefore, we should use a well-defined function not a bit shift
> to find the header length.
>
> It also compresses two lines to a single line.
>
> Signed-off-by: Moon Yeounsu <yyyynoom@gmail.com>
Reviewed-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> v1: use ip_hdrlen() instead of bit shift
> Reference: https://lore.kernel.org/all/20240802054421.5428-1-yyyynoom@gmail.com/
>
> v2: remove unnecessary parentheses
> - Remove extra () [Christophe Jaillet, Simon Horman]
> - Break long lines [Simon Horman]
> Reference: https://lore.kernel.org/all/20240803022949.28229-1-yyyynoom@gmail.com/
>
> v3: create a standalone patch
> - Start with a new thread
> - Include the change logs,
> - Create a standalone patch [Christophe Jaillet]
>
> drivers/net/ethernet/jme.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
> index b06e24562973..d8be0e4dcb07 100644
> --- a/drivers/net/ethernet/jme.c
> +++ b/drivers/net/ethernet/jme.c
> @@ -946,15 +946,13 @@ jme_udpsum(struct sk_buff *skb)
> if (skb->protocol != htons(ETH_P_IP))
> return csum;
> skb_set_network_header(skb, ETH_HLEN);
> - if ((ip_hdr(skb)->protocol != IPPROTO_UDP) ||
> - (skb->len < (ETH_HLEN +
> - (ip_hdr(skb)->ihl << 2) +
> - sizeof(struct udphdr)))) {
> +
> + if (ip_hdr(skb)->protocol != IPPROTO_UDP ||
> + skb->len < (ETH_HLEN + ip_hdrlen(skb) + sizeof(struct udphdr))) {
> skb_reset_network_header(skb);
> return csum;
> }
> - skb_set_transport_header(skb,
> - ETH_HLEN + (ip_hdr(skb)->ihl << 2));
> + skb_set_transport_header(skb, ETH_HLEN + ip_hdrlen(skb));
> csum = udp_hdr(skb)->check;
> skb_reset_transport_header(skb);
> skb_reset_network_header(skb);
next prev parent reply other threads:[~2024-08-07 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 10:07 Moon Yeounsu
2024-08-07 12:28 ` Christophe JAILLET [this message]
2024-08-11 3:52 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4850b81e-d426-4abd-87f8-2712cd0b5de4@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yyyynoom@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®