From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Leo Yan <leo.yan@linaro.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Will Deacon <will@kernel.org>, James Morse <james.morse@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools headers arm64: Fix compilation failure
Date: Thu, 11 Aug 2022 11:11:41 +0100 [thread overview]
Message-ID: <48524c3d-c858-15ec-ac79-9547f3489b7b@arm.com> (raw)
In-Reply-To: <20220811044341.426796-1-leo.yan@linaro.org>
Hi Leo
On 11/08/2022 05:43, Leo Yan wrote:
> When build perf tool on x86_64, it reports failure for finding the
> header <asm/sysreg.h>:
>
Please could you mention the exact build options used for the perf
build ? (e.g, enable SPE)
> In file included from util/arm-spe.c:37:
> util/../../arch/arm64/include/asm/cputype.h:183:10: fatal error: asm/sysreg.h: No such file or directory
> 183 | #include <asm/sysreg.h>
> | ^~~~~~~~~~~~~~
> compilation terminated.
> > There have no sysreg.h in x86's asm folder, alternatively, this patch
> includes the sysreg.h header in the same folder with cputype.h to fix
> the compilation failure.
Wondering how the "cputype.h" was picked up from arch/arm64/include/ and
why not the sysreg.h ? Ideally, we would like to pickup the kernel
headers as it is without having to manually fixup, things like this.
>
> Fixes: 37402d5d061b ("tools headers arm64: Sync arm64's cputype.h with the kernel sources")
Also from the above commit,
"That addresses this perf build warning:
Warning: Kernel ABI header at
'tools/arch/arm64/include/asm/cputype.h' differs from latest version at
'arch/arm64/include/asm/cputype.h'
diff -u tools/arch/arm64/include/asm/cputype.h
arch/arm64/include/asm/cputype.h
"
Wouldn't we re-introduce the warning back ?
Suzuki
next prev parent reply other threads:[~2022-08-11 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 4:43 Leo Yan
2022-08-11 10:11 ` Suzuki K Poulose [this message]
2022-08-11 12:48 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48524c3d-c858-15ec-ac79-9547f3489b7b@arm.com \
--to=suzuki.poulose@arm.com \
--cc=acme@redhat.com \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®