From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2E88238C2D1; Tue, 18 Aug 2026 07:31:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787038309; cv=none; b=Y0KAmnVuoqFmnOX8W5/UaC7a0UVPXkKLj5lm2jjtKBuCs5/SRtgl12TPRwE51EkFujnNtzMG9IJczc1bSlCUfLxZoih4lFCT1IC2dgiuZYTdZaRL1Xf+5SQ2FWKLLNK3Frs16nneoLivIfFTBwMaG6k530arbGM8iVJt7+7qTBU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787038309; c=relaxed/simple; bh=kd+aEj7HiYh+uDssfc1Wr0UmfDCUi/qlYwIPAE9dhi8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=STLbXjPYuTwmtLNhrqdmQ9KAaO8tY3ez3HyAr6TSna7tBEfUb9uuZ+n0kxPoAwhiZ7o6XM7kcFBGfM5MdS3M2yuidMCEKAZpnZl7WL6AzWIw6QRhRm5O7MLBNVOMnjQSRUs/kUeoAe/gTw0WJ9AnJVqitZR+vOjfRB0SWwxZZFU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=fUrsCUDT; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="fUrsCUDT" Received: from [192.168.1.70] (unknown [4.194.122.170]) by linux.microsoft.com (Postfix) with ESMTPSA id 8C44620B7168; Tue, 18 Aug 2026 00:31:05 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8C44620B7168 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1787038272; bh=of93UnPxr+GXvnkB7oIT0Kq8tP1Ii3Vu6hCXuqd00bY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fUrsCUDTT67KQ9cLJTU/H2jJrANa28ZXqOpX+jLlVHkFOQpJJ15XzM6i2xU5jTSGO rrJGx255ysvW8R74ebl0P3GT1axkG/Lbn3xNYCyhv6Pqyq4zGV7mQjpteiKXjA7mXe ATlKrxgLFoh1M6zGY7CH+orkIlzVzS0/grgUqQHs= Message-ID: <4852d87f-0fba-476b-8a91-15afa89705e8@linux.microsoft.com> Date: Tue, 18 Aug 2026 13:01:24 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] x86/irq, iommu/amd, PCI: Drop redundant irq_retrigger inits To: Michael Kelley , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "Joerg Roedel (AMD)" , Will Deacon , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas Cc: "H. Peter Anvin" , Suravee Suthikulpanit , Vasant Hegde , Robin Murphy , Rob Herring , Shradha Gupta , Aditya Garg , "iommu@lists.linux.dev" , "linux-hyperv@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20260810090716.2325295-1-namjain@linux.microsoft.com> <20260810090716.2325295-4-namjain@linux.microsoft.com> Content-Language: en-US From: Naman Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/18/2026 10:40 AM, Michael Kelley wrote: > From: Naman Jain Sent: Monday, August 10, 2026 2:07 AM >> >> With fixup_irqs() now using irq_chip_retrigger_hierarchy() and the generic >> resend path (try_retrigger()) already falling back to it, installing >> irq_chip_retrigger_hierarchy() as the irq_retrigger() callback on the >> outermost domain chips is no longer required. The hierarchy walk reaches >> the x86 vector domain's apic_retrigger_irq() for all of these stacked >> domain chips. >> >> Remove the now redundant irq_retrigger() initializations from the outermost >> domain interrupt chips. >> msi_set_affinity() is the only site that invoked the outermost chip's >> irq_retrigger() directly. Convert it to irq_chip_retrigger_hierarchy() so >> the x86_init_dev_msi_info() initialization can be dropped as well. >> >> No functional change intended. >> >> Suggested-by: Thomas Gleixner >> Reviewed-by: Shradha Gupta >> Signed-off-by: Naman Jain >> --- >> arch/x86/kernel/apic/io_apic.c | 2 -- >> arch/x86/kernel/apic/msi.c | 4 +--- >> arch/x86/kernel/hpet.c | 1 - >> drivers/iommu/amd/init.c | 1 - >> drivers/pci/controller/pci-hyperv.c | 1 - >> 5 files changed, 1 insertion(+), 8 deletions(-) >> >> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c >> index 7d7175d012288..18f49a251f23b 100644 >> --- a/arch/x86/kernel/apic/io_apic.c >> +++ b/arch/x86/kernel/apic/io_apic.c >> @@ -1857,7 +1857,6 @@ static struct irq_chip ioapic_chip __read_mostly = { >> .irq_ack = irq_chip_ack_parent, >> .irq_eoi = ioapic_ack_level, >> .irq_set_affinity = ioapic_set_affinity, >> - .irq_retrigger = irq_chip_retrigger_hierarchy, >> .irq_get_irqchip_state = ioapic_irq_get_chip_state, >> .flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MOVE_DEFERRED | >> IRQCHIP_AFFINITY_PRE_STARTUP, >> @@ -1871,7 +1870,6 @@ static struct irq_chip ioapic_ir_chip __read_mostly = { >> .irq_ack = irq_chip_ack_parent, >> .irq_eoi = ioapic_ir_ack_level, >> .irq_set_affinity = ioapic_set_affinity, >> - .irq_retrigger = irq_chip_retrigger_hierarchy, >> .irq_get_irqchip_state = ioapic_irq_get_chip_state, >> .flags = IRQCHIP_SKIP_SET_WAKE | >> IRQCHIP_AFFINITY_PRE_STARTUP, >> diff --git a/arch/x86/kernel/apic/msi.c b/arch/x86/kernel/apic/msi.c >> index 66bc5d3e79db3..aad2f15eb2176 100644 >> --- a/arch/x86/kernel/apic/msi.c >> +++ b/arch/x86/kernel/apic/msi.c >> @@ -137,7 +137,7 @@ msi_set_affinity(struct irq_data *irqd, const struct cpumask *mask, bool force) >> * IRR. >> */ >> if (lapic_vector_set_in_irr(cfg->vector)) >> - irq_data_get_irq_chip(irqd)->irq_retrigger(irqd); >> + irq_chip_retrigger_hierarchy(irqd); > > Again, this will miss the outermost chip's retrigger function if it > is set to something custom. > > Michael In case we all agree to adding a fallback in previous patch, I am afraid, we will have to add it here as well. Regards, Naman > >> >> return ret; >> } >> @@ -246,7 +246,6 @@ static bool x86_init_dev_msi_info(struct device *dev, struct irq_domain *domain, >> info->ops->msi_prepare = x86_msi_prepare; >> >> info->chip->irq_ack = irq_chip_ack_parent; >> - info->chip->irq_retrigger = irq_chip_retrigger_hierarchy; >> info->chip->flags |= IRQCHIP_SKIP_SET_WAKE | >> IRQCHIP_AFFINITY_PRE_STARTUP; >> >> @@ -313,7 +312,6 @@ static struct irq_chip dmar_msi_controller = { >> .irq_mask = dmar_msi_mask, >> .irq_ack = irq_chip_ack_parent, >> .irq_set_affinity = msi_domain_set_affinity, >> - .irq_retrigger = irq_chip_retrigger_hierarchy, >> .irq_compose_msi_msg = dmar_msi_compose_msg, >> .irq_write_msi_msg = dmar_msi_write_msg, >> .flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MOVE_DEFERRED | >> diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c >> index 8dc7b710e1250..2bb7a6f466af3 100644 >> --- a/arch/x86/kernel/hpet.c >> +++ b/arch/x86/kernel/hpet.c >> @@ -509,7 +509,6 @@ static struct irq_chip hpet_msi_controller __ro_after_init = { >> .irq_mask = hpet_msi_mask, >> .irq_ack = irq_chip_ack_parent, >> .irq_set_affinity = msi_domain_set_affinity, >> - .irq_retrigger = irq_chip_retrigger_hierarchy, >> .irq_write_msi_msg = hpet_msi_write_msg, >> .flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_AFFINITY_PRE_STARTUP, >> }; >> diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c >> index ea3377e61aa5c..0c362e86a09d9 100644 >> --- a/drivers/iommu/amd/init.c >> +++ b/drivers/iommu/amd/init.c >> @@ -2468,7 +2468,6 @@ static struct irq_chip intcapxt_controller = { >> .irq_unmask = intcapxt_unmask_irq, >> .irq_mask = intcapxt_mask_irq, >> .irq_ack = irq_chip_ack_parent, >> - .irq_retrigger = irq_chip_retrigger_hierarchy, >> .irq_set_affinity = intcapxt_set_affinity, >> .irq_set_wake = intcapxt_set_wake, >> .flags = IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_MOVE_DEFERRED, >> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c >> index 89816a2bd7cd3..cfc8fa403dad6 100644 >> --- a/drivers/pci/controller/pci-hyperv.c >> +++ b/drivers/pci/controller/pci-hyperv.c >> @@ -2119,7 +2119,6 @@ static bool hv_pcie_init_dev_msi_info(struct device *dev, >> struct irq_domain *dom >> info->ops->msi_prepare = hv_msi_prepare; >> >> chip->irq_set_affinity = irq_chip_set_affinity_parent; >> - chip->irq_retrigger = irq_chip_retrigger_hierarchy; >> >> if (IS_ENABLED(CONFIG_X86)) >> chip->flags |= IRQCHIP_MOVE_DEFERRED; >> -- >> 2.43.0 >>