From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755906AbcEETKJ (ORCPT ); Thu, 5 May 2016 15:10:09 -0400 Received: from lists.s-osg.org ([54.187.51.154]:50919 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753503AbcEETKG (ORCPT ); Thu, 5 May 2016 15:10:06 -0400 Subject: Re: [RFC v2 05/13] power: pwrseq: Remove mmc prefix from mmc_pwrseq To: Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-mmc@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, Ulf Hansson , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Greg Kroah-Hartman , Mark Brown References: <1462451666-17945-1-git-send-email-k.kozlowski@samsung.com> <1462451666-17945-6-git-send-email-k.kozlowski@samsung.com> Cc: tjakobi@math.uni-bielefeld.de, m.szyprowski@samsung.com, hverkuil@xs4all.nl, Bartlomiej Zolnierkiewicz From: Javier Martinez Canillas Message-ID: <48539995-2966-0df0-51db-e0c549a92880@osg.samsung.com> Date: Thu, 5 May 2016 15:09:52 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1462451666-17945-6-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 05/05/2016 08:34 AM, Krzysztof Kozlowski wrote: > The "mmc" prefix is no longer needed after moving the pwrseq core code > from mmc/ to power/. > > Signed-off-by: Krzysztof Kozlowski > --- [snip] > diff --git a/drivers/power/pwrseq/pwrseq_emmc.c b/drivers/power/pwrseq/pwrseq_emmc.c > index a0583ed46d7f..a68ac9a68e04 100644 > --- a/drivers/power/pwrseq/pwrseq_emmc.c > +++ b/drivers/power/pwrseq/pwrseq_emmc.c > @@ -22,7 +22,7 @@ > #include > I don't think this header inclusion is needed. At least I didn't see anything defined there that's used in this driver. This also applies to pwrseq_simple. I think you could remove those in another preparatory patches before the move. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America