From: "Jan Beulich" <jbeulich@novell.com>
To: <mingo@elte.hu>, <tglx@linutronix.de>, <hpa@zytor.com>
Cc: "Andi Kleen" <andi@firstfloor.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86-64: remove unnecessary ptregs call stubs
Date: Wed, 18 Jun 2008 12:42:11 +0100 [thread overview]
Message-ID: <485910B3.76E4.0078.0@novell.com> (raw)
A few of the ptregs call stubs are superfluous these days - the called
functions don't have a trailing 'struct pt_regs *' parameter anymore.
Cc: Andi Kleen <andi@firstfloor.org>
Signed-off-by: Jan Beulich <jbeulich@novell.com>
---
arch/x86/ia32/ia32entry.S | 6 ++----
arch/x86/kernel/entry_64.S | 1 -
include/asm-x86/unistd_64.h | 2 +-
3 files changed, 3 insertions(+), 6 deletions(-)
--- linux-2.6.26-rc6/arch/x86/ia32/ia32entry.S 2008-06-18 12:49:29.000000000 +0200
+++ 2.6.26-rc6-x86_64-remove-ptregs-stubs/arch/x86/ia32/ia32entry.S 2008-06-11 12:26:13.000000000 +0200
@@ -370,13 +370,11 @@ quiet_ni_syscall:
PTREGSCALL stub32_rt_sigreturn, sys32_rt_sigreturn, %rdi
PTREGSCALL stub32_sigreturn, sys32_sigreturn, %rdi
PTREGSCALL stub32_sigaltstack, sys32_sigaltstack, %rdx
- PTREGSCALL stub32_sigsuspend, sys32_sigsuspend, %rcx
PTREGSCALL stub32_execve, sys32_execve, %rcx
PTREGSCALL stub32_fork, sys_fork, %rdi
PTREGSCALL stub32_clone, sys32_clone, %rdx
PTREGSCALL stub32_vfork, sys_vfork, %rdi
PTREGSCALL stub32_iopl, sys_iopl, %rsi
- PTREGSCALL stub32_rt_sigsuspend, sys_rt_sigsuspend, %rdx
ENTRY(ia32_ptregs_common)
popq %r11
@@ -476,7 +474,7 @@ ia32_sys_call_table:
.quad sys_ssetmask
.quad sys_setreuid16 /* 70 */
.quad sys_setregid16
- .quad stub32_sigsuspend
+ .quad sys32_sigsuspend
.quad compat_sys_sigpending
.quad sys_sethostname
.quad compat_sys_setrlimit /* 75 */
@@ -583,7 +581,7 @@ ia32_sys_call_table:
.quad sys32_rt_sigpending
.quad compat_sys_rt_sigtimedwait
.quad sys32_rt_sigqueueinfo
- .quad stub32_rt_sigsuspend
+ .quad sys_rt_sigsuspend
.quad sys32_pread /* 180 */
.quad sys32_pwrite
.quad sys_chown16
--- linux-2.6.26-rc6/arch/x86/kernel/entry_64.S 2008-06-18 12:49:29.000000000 +0200
+++ 2.6.26-rc6-x86_64-remove-ptregs-stubs/arch/x86/kernel/entry_64.S 2008-06-11 12:24:52.000000000 +0200
@@ -420,7 +420,6 @@ END(\label)
PTREGSCALL stub_clone, sys_clone, %r8
PTREGSCALL stub_fork, sys_fork, %rdi
PTREGSCALL stub_vfork, sys_vfork, %rdi
- PTREGSCALL stub_rt_sigsuspend, sys_rt_sigsuspend, %rdx
PTREGSCALL stub_sigaltstack, sys_sigaltstack, %rdx
PTREGSCALL stub_iopl, sys_iopl, %rsi
--- linux-2.6.26-rc6/include/asm-x86/unistd_64.h 2008-06-18 12:49:47.000000000 +0200
+++ 2.6.26-rc6-x86_64-remove-ptregs-stubs/include/asm-x86/unistd_64.h 2008-06-11 12:29:56.000000000 +0200
@@ -290,7 +290,7 @@ __SYSCALL(__NR_rt_sigtimedwait, sys_rt_s
#define __NR_rt_sigqueueinfo 129
__SYSCALL(__NR_rt_sigqueueinfo, sys_rt_sigqueueinfo)
#define __NR_rt_sigsuspend 130
-__SYSCALL(__NR_rt_sigsuspend, stub_rt_sigsuspend)
+__SYSCALL(__NR_rt_sigsuspend, sys_rt_sigsuspend)
#define __NR_sigaltstack 131
__SYSCALL(__NR_sigaltstack, stub_sigaltstack)
#define __NR_utime 132
next reply other threads:[~2008-06-18 11:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-18 11:42 Jan Beulich [this message]
2008-06-19 12:25 ` Ingo Molnar
2008-06-19 12:50 ` Andi Kleen
2008-06-19 14:32 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485910B3.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®