From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C26BC43334 for ; Mon, 20 Jun 2022 09:17:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240665AbiFTJRC (ORCPT ); Mon, 20 Jun 2022 05:17:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236337AbiFTJQ7 (ORCPT ); Mon, 20 Jun 2022 05:16:59 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 872DD101E6; Mon, 20 Jun 2022 02:16:50 -0700 (PDT) X-UUID: 36eef338cfb74a14ab06673e7c6a772d-20220620 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.6,REQID:14f07526-6b8b-4088-ae29-c2bd702ee75f,OB:10,L OB:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,AC TION:release,TS:45 X-CID-INFO: VERSION:1.1.6,REQID:14f07526-6b8b-4088-ae29-c2bd702ee75f,OB:10,LOB :0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:45 X-CID-META: VersionHash:b14ad71,CLOUDID:2f7effe9-f7af-4e69-92ee-0fd74a0c286c,C OID:a7e4c246682a,Recheck:0,SF:28|17|19|48,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,QS:nil,BEC:nil,COL:0 X-UUID: 36eef338cfb74a14ab06673e7c6a772d-20220620 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 401679810; Mon, 20 Jun 2022 17:16:43 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Mon, 20 Jun 2022 17:16:42 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Mon, 20 Jun 2022 17:16:41 +0800 Message-ID: <485c9b07fb2a60635e7cd52e710af872733fcff9.camel@mediatek.com> Subject: Re: [PATCH v3 1/4] dt-bindings: dsp: mediatek: Use meaningful names for mbox From: Tinghan Shen To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta , Mark Brown , Jaroslav Kysela , "Takashi Iwai" , YC Hung , Curtis Malainey , Allen-KH Cheng CC: , , , , , , Date: Mon, 20 Jun 2022 17:16:41 +0800 In-Reply-To: <3830efc5-298d-7887-5718-2cb2a7ad4895@linaro.org> References: <20220616073042.13229-1-tinghan.shen@mediatek.com> <20220616073042.13229-2-tinghan.shen@mediatek.com> <629e761b-e3ad-0861-1937-ad660a8a900b@linaro.org> <3830efc5-298d-7887-5718-2cb2a7ad4895@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Mon, 2022-06-20 at 10:51 +0200, Krzysztof Kozlowski wrote: > On 20/06/2022 08:40, Tinghan Shen wrote: > > Hi Krzysztof, > > > > On Thu, 2022-06-16 at 06:55 -0700, Krzysztof Kozlowski wrote: > > > On 16/06/2022 00:30, Tinghan Shen wrote: > > > > Rename mbox according to actions instead of 'mbox0' and 'mbox1'. > > > > > > > > Signed-off-by: Tinghan Shen > > > > --- > > > > .../devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml | 10 +++++----- > > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml > > > > b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml > > > > index b7e68b0dfa13..ca8d8661f872 100644 > > > > --- a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml > > > > +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml > > > > @@ -50,13 +50,13 @@ properties: > > > > > > > > mboxes: > > > > items: > > > > - - description: ipc reply between host and audio DSP. > > > > - - description: ipc request between host and audio DSP. > > > > + - description: mailbox for receiving audio DSP requests. > > > > + - description: mailbox for transmitting requests to audio DSP. > > > > > > > > mbox-names: > > > > items: > > > > - - const: mbox0 > > > > - - const: mbox1 > > > > + - const: rx > > > > + - const: tx > > > > > > > > > > Commit msg lacks important piece - do you break any users with this? Do > > > you have any users of this binding? > > > > > > > > > Best regards, > > > Krzysztof > > > > The 8195 dsp node, which uses this binding, has not yet been added to the 8195 devicetree. > > Could you mention it in the commit msg? Such one sentence is enough. > > With commit msg extended: > > Reviewed-by: Krzysztof Kozlowski > > > Best regards, > Krzysztof No problem. I'll udpate commit message at next version. Thanks, TingHan