mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Linux Doc Mailing List <linux-doc@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Mauro Carvalho Chehab <mchehab@infradead.org>,
	linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>
Subject: [PATCH v2 09/16] scripts/get_abi.pl: fix parse issues with some files
Date: Fri, 14 Jun 2019 14:52:23 -0300	[thread overview]
Message-ID: <485e3e80bbddc4e144bc1d110f980ace092c5e1c.1560534648.git.mchehab+samsung@kernel.org> (raw)
In-Reply-To: <3b8d7c64f887ddea01df3c4eeabc745c8ec45406.1560534648.git.mchehab+samsung@kernel.org>

A few files are failing to parse:

	Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats
	Documentation/ABI/testing/sysfs-class-pktcdvd
	Documentation/ABI/testing/sysfs-bus-nfit

On all three files, the problem is that there is a ":" character
at the initial file description.

Improve the parse in order to handle those special cases.

Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
---
 scripts/get_abi.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/get_abi.pl b/scripts/get_abi.pl
index 7d454e359d25..116f0c33c16d 100755
--- a/scripts/get_abi.pl
+++ b/scripts/get_abi.pl
@@ -87,7 +87,7 @@ sub parse_abi {
 					# New "tag" is actually part of
 					# description. Don't consider it a tag
 					$new_tag = "";
-				} else {
+				} elsif ($tag ne "") {
 					parse_error($file, $ln, "tag '$tag' is invalid", $_);
 				}
 			}
@@ -110,7 +110,7 @@ sub parse_abi {
 				next;
 			}
 
-			if ($new_tag) {
+			if ($tag ne "" && $new_tag) {
 				$tag = $new_tag;
 
 				if ($new_what) {
-- 
2.21.0


  parent reply	other threads:[~2019-06-14 17:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 17:52 [PATCH v2 01/16] ABI: sysfs-bus-pci-devices-aer_stats uses an invalid tag Mauro Carvalho Chehab
2019-06-14 17:52 ` [PATCH v2 02/16] ABI: Fix KernelVersion tags Mauro Carvalho Chehab
2019-06-14 17:52 ` [PATCH v2 03/16] scripts: add an script to parse the ABI files Mauro Carvalho Chehab
2019-06-17 12:57   ` Greg Kroah-Hartman
2019-06-14 17:52 ` [PATCH v2 04/16] scripts/get_abi.pl: parse files with text at beginning Mauro Carvalho Chehab
2019-06-14 17:52 ` [PATCH v2 05/16] scripts/get_abi.pl: avoid use literal blocks when not needed Mauro Carvalho Chehab
2019-06-14 17:52 ` [PATCH v2 06/16] scripts/get_abi.pl: split label naming from xref logic Mauro Carvalho Chehab
2019-06-14 17:52 ` [PATCH v2 07/16] scripts/get_abi.pl: add support for searching for ABI symbols Mauro Carvalho Chehab
2019-06-14 17:52 ` [PATCH v2 08/16] scripts/get_abi.pl: represent what in tables Mauro Carvalho Chehab
2019-06-14 17:52 ` Mauro Carvalho Chehab [this message]
2019-06-14 17:52 ` [PATCH v2 10/16] scripts/get_abi.pl: avoid creating duplicate names Mauro Carvalho Chehab
2019-06-14 17:52 ` [PATCH v2 11/16] scripts/get_abi.pl: add a handler for invalid "where" tag Mauro Carvalho Chehab
2019-06-14 17:52 ` [PATCH v2 12/16] scripts/get_abi.pl: add a validate command Mauro Carvalho Chehab
2019-06-14 17:52 ` [PATCH v2 13/16] doc-rst: add ABI documentation to the admin-guide book Mauro Carvalho Chehab
2019-06-14 17:52 ` [PATCH v2 14/16] docs: sphinx/kernel_abi.py: fix UTF-8 support Mauro Carvalho Chehab
2019-06-14 17:52 ` [PATCH v2 15/16] sphinx/kernel_abi.py: make it compatible with Sphinx 1.7+ Mauro Carvalho Chehab
2019-06-14 17:52 ` [PATCH v2 16/16] docs: Kconfig/Makefile: add a check for broken ABI files Mauro Carvalho Chehab
2019-06-14 18:07 ` [PATCH v2 00/16] Add support to generate ABI documentation at admin-guide Mauro Carvalho Chehab
2019-06-15  6:15   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=485e3e80bbddc4e144bc1d110f980ace092c5e1c.1560534648.git.mchehab+samsung@kernel.org \
    --to=mchehab+samsung@kernel.org \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®