From: Harshal Dev <harshal.dev@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Sumit Garg <sumit.garg@oss.qualcomm.com>
Cc: Sumit Garg <sumit.garg@kernel.org>,
linux-arm-msm@vger.kernel.org, andersson@kernel.org,
konradybcio@kernel.org, linux-kernel@vger.kernel.org,
bartosz.golaszewski@oss.qualcomm.com,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] firmware: qcom: scm: fold tzmem into the qcom-scm module
Date: Tue, 21 Jul 2026 11:24:42 +0530 [thread overview]
Message-ID: <48619593-777a-48eb-8c7b-cfee1492376c@oss.qualcomm.com> (raw)
In-Reply-To: <98d6d638-bc5c-4a4f-b587-44b61df63d34@oss.qualcomm.com>
Hi Sumit,
On 14-07-2026 09:08 pm, Konrad Dybcio wrote:
> On 7/14/26 8:25 AM, Harshal Dev wrote:
>> Hi,
>>
>> On 7/13/2026 5:05 PM, Sumit Garg wrote:
>>> On Mon, Jul 13, 2026 at 4:07 PM Konrad Dybcio
>>> <konrad.dybcio@oss.qualcomm.com> wrote:
>>>>
>>>> On 7/13/26 6:58 AM, Sumit Garg wrote:
>>>>> From: Sumit Garg <sumit.garg@oss.qualcomm.com>
>
> [...]
>
>>>>> --- a/drivers/firmware/qcom/Makefile
>>>>> +++ b/drivers/firmware/qcom/Makefile
>>>>> @@ -5,7 +5,7 @@
>>>>>
>>>>> obj-$(CONFIG_QCOM_SCM) += qcom-scm.o
>>>>> qcom-scm-objs += qcom_scm.o qcom_scm-smc.o qcom_scm-legacy.o
>>>>> -obj-$(CONFIG_QCOM_TZMEM) += qcom_tzmem.o
>>>>> +qcom-scm-$(CONFIG_QCOM_TZMEM) += qcom_tzmem.o
>>>>
>>>> Does it make sense to squash the kconfig entries too now?
>>>>
>>>
>>> Sounds reasonable to me, I can do that for v2.
>>
>> What kind of squash are we thinking about here? Moving the TZMEM_MODE* choice to
>> QCOM_SCM and removing QCOM_TZMEM? I think we should keep the QCOM_TZMEM Kconfig
>> around for when we boot with OPTEE and want to disable TZMEM since SHMBridge is
>> QTEE specific.
>
> Hmm, fair.
If you are aligned with not performing any Kconfig squashes for now feel free to
add my tag:
Reviewed-by: Harshal Dev <harshal.dev@oss.qualcomm.com>
Regards,
Harshal
>
> Konrad
next prev parent reply other threads:[~2026-07-21 5:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 4:58 Sumit Garg
2026-07-13 10:37 ` Konrad Dybcio
2026-07-13 11:35 ` Sumit Garg
2026-07-14 6:25 ` Harshal Dev
2026-07-14 15:38 ` Konrad Dybcio
2026-07-21 5:54 ` Harshal Dev [this message]
2026-07-21 10:05 ` Sumit Garg
2026-09-10 7:17 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48619593-777a-48eb-8c7b-cfee1492376c@oss.qualcomm.com \
--to=harshal.dev@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=sumit.garg@kernel.org \
--cc=sumit.garg@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®