mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org,
	RussianNeuroMancer <russianneuromancer@ya.ru>,
	David Ward <david.ward@ll.mit.edu>,
	Frederick Lawler <fred@fredlawl.com>,
	Patrick Talbert <ptalbert@redhat.com>,
	Lukas Wunner <lukas@wunner.de>,
	Srinath Mannam <srinath.mannam@broadcom.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Vidya Sagar <vidyas@nvidia.com>,
	Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/2] PCI/ASPM: Fix LTR issues
Date: Fri, 22 Feb 2019 10:37:34 +0100	[thread overview]
Message-ID: <4865264.tNTiON9z6m@aspire.rjw.lan> (raw)
In-Reply-To: <20190222045824.GD219879@google.com>

On Friday, February 22, 2019 5:58:24 AM CET Bjorn Helgaas wrote:
> On Mon, Feb 11, 2019 at 04:55:33PM -0600, Bjorn Helgaas wrote:
> > These are to fix a couple LTR-related issues found while investigating
> > https://bugzilla.kernel.org/show_bug.cgi?id=201469
> > 
> > I don't claim that these fix the whole problem of that bugzilla, but I
> > think it's pretty clear that these are problems we need to fix, so I want
> > to give these a little more exposure.
> > 
> > Feedback welcome!
> > 
> > ---
> > 
> > Bjorn Helgaas (2):
> >       PCI/ASPM: Use LTR if already enabled by platform
> >       PCI/ASPM: Save LTR Capability for suspend/resume
> > 
> > 
> >  drivers/pci/pci.c   |   53 +++++++++++++++++++++++++++++++++++++++++++++++++--
> >  drivers/pci/probe.c |   36 ++++++++++++++++++++++-------------
> >  2 files changed, 74 insertions(+), 15 deletions(-)
> 
> I applied these to pci/aspm for v5.1.
> 
> I think Vidya is absolutely right that we also need to save/restore
> the ASPM L1 Substates capability.  But I haven't had a chance to
> write that up yet, and I think these two patches by themselves
> are an improvement even without ASPM L1 SS.

Agreed.

Cheers,
Rafael


      reply	other threads:[~2019-02-22  9:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-11 22:55 Bjorn Helgaas
2019-02-11 22:55 ` [PATCH v1 1/2] PCI/ASPM: Use LTR if already enabled by platform Bjorn Helgaas
2019-02-11 22:55 ` [PATCH v1 2/2] PCI/ASPM: Save LTR Capability for suspend/resume Bjorn Helgaas
2019-02-13  5:23   ` Vidya Sagar
2019-02-13 17:40     ` Bjorn Helgaas
2019-02-22  4:58 ` [PATCH v1 0/2] PCI/ASPM: Fix LTR issues Bjorn Helgaas
2019-02-22  9:37   ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4865264.tNTiON9z6m@aspire.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=david.ward@ll.mit.edu \
    --cc=emmanuel.grumbach@intel.com \
    --cc=fred@fredlawl.com \
    --cc=helgaas@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=ptalbert@redhat.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=russianneuromancer@ya.ru \
    --cc=srinath.mannam@broadcom.com \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®