Re: [PATCH v2 0/5] platform/x86: uniwill-laptop: Lightbar fixes

[Rong Zhang <i@rong.moe>]

Hi Armin, Ilpo,

On Sat, 2026-10-10 at 03:22 +0200, Armin Wolf wrote:
> Am 08.10.26 um 19:38 schrieb Ilpo Järvinen:
> 
> > On Wed, 07 Oct 2026 16:38:53 +0200, Armin Wolf wrote:
> > 
> > > This patch series mainly deals with various issues inside the code
> > > responsible for controlling the lightbar on supported devices.
> > > 
> > > The first patch utilizes the improved multicolor LED API to report
> > > the correct brightness of the lightbar to userspace. The next two
> > > patches fix issues discovered inside the code for controlling
> > > animations, while the fourth patch fixes an issue with the naming
> > > of the LEDs in general. The last patch also adds support for another
> > > variant of the Intel NUC x15 laptop kit.
> > > 
> > > [...]
> > Thank you for your contribution, it has been applied to my local
> > review-ilpo-next branch. Note it will show up in the public
> > platform-drivers-x86/review-ilpo-next branch only once I've pushed my
> > local branch there, which might take a while.
> 
> Thank you :)
> 
> I noticed that the LED next branch contains a commit that requires triggers
> to implement a new callback and prints a warning if this is not the case.

Whoops, I didn't realize there was another private trigger being added
during the same cycle.

I have some additional review comments on the implementation of the
private trigger. See my reply to the relevant patch.

> 
> Should i wait till the next cycle to send a patch implementing said callback
> or do you want to rebase for-next onto LED next?

I would like to ask a similar question, too. The leds part of my series
has been applied[1], leaving the pdx86 part waiting for further review or
apply.

Ilpo, may I ask about your preference here? Would you prefer to merge LED
next and apply the pdx86 part[2] of my series this cycle, or prefer to
wait until the next cycle? If the latter is preferred, should I resubmit
the series then?

[1]: https://lore.kernel.org/all/179025272986.499136.14712876777665893306.b4-ty@b4/
[2]: https://lore.kernel.org/all/20260921-leds-trigger-hw-changed-v7-11-fe3cdb6dec51@rong.moe/

Thanks,
Rong

> 
> Thanks,
> Armin Wolf
> 
> > FYI [if applicable to your patch], as per Linus' policy change, also
> > fixes are mostly routed through for-next unless the fix is for a
> > commit introduced in the most recent cycle or is clearly a regression
> > fix.
> > 
> > The list of commits applied:
> > [1/5] platform/x86: uniwill-laptop: Report correct lightbar brightness
> >        commit: de41d8b4d0dbb81c81cd99c245238d878a3e1951
> > [2/5] platform/x86: uniwill-laptop: Implement rainbow animation as trigger
> >        commit: 59e4e406b6c08ad41f3ad86db6d42b82d8539c12
> > [3/5] platform/x86: uniwill-laptop: Fix breathing animation on Intel QC
> >        commit: 969a3bfa474e35828e142d0160f393a97d9bf0ee
> > [4/5] platform/x86: uniwill-laptop: Label multicolor LEDs correctly
> >        commit: 42e6b269fc1134a3fcce57539034ee496e2c1344
> > [5/5] platform/x86: uniwill-laptop: Extend support for the Intel NUC x15
> >        commit: 7a159a14ce0f5d5a3c2f835f39986ec5539ae374
> > 
> > --
> >   i.
> > 
> >