From: Frank Rowand <frowand.list@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: refcount leak when phandle_cache entry replaced
Date: Thu, 12 Dec 2019 05:17:29 -0600 [thread overview]
Message-ID: <486ce60c-8a74-7baf-1054-c81c83e79e56@gmail.com> (raw)
In-Reply-To: <20191211201856.GA21857@bogus>
On 12/11/19 2:18 PM, Rob Herring wrote:
> On Tue, 10 Dec 2019 02:14:53 -0600, frowand.list@gmail.com wrote:
>> From: Frank Rowand <frank.rowand@sony.com>
>>
>> of_find_node_by_phandle() does not do an of_node_put() of the existing
>> node in a phandle cache entry when that node is replaced by a new node.
>>
>> Reported-by: Rob Herring <robh+dt@kernel.org>
>> Fixes: b8a9ac1a5b99 ("of: of_node_get()/of_node_put() nodes held in phandle cache")
>> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
>> ---
>>
>> Checkpatch will warn about a line over 80 characters. Let me know
>> if that bothers you.
>>
>> drivers/of/base.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>
> Applied, thanks.
>
> Rob
>
If the rework patch of the cache that you posted shortly after accepting
my patch, then my patch becomes not needed and is just extra noise in the
history. Once your patch finishes review (I am assuming it probably
will), then my patch should be reverted.
-Frank
next prev parent reply other threads:[~2019-12-12 11:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 8:14 frowand.list
2019-12-11 20:18 ` Rob Herring
2019-12-12 11:17 ` Frank Rowand [this message]
2019-12-12 14:00 ` Rob Herring
2019-12-19 15:57 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486ce60c-8a74-7baf-1054-c81c83e79e56@gmail.com \
--to=frowand.list@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®