From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AB053E315F for ; Wed, 6 May 2026 10:47:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778064480; cv=none; b=pO4OqFhXjiWc4szSaN7PwzBt5uqGsSjWHLk53JJP1kCzNTUz2XwVQ9pYwmOYyZaKIkPqKNkIPiCe5ifRaUiIhClRfuYsHoB0dTLJgt/8XKwjhW3wiiBF0ScRSz1uaJUrLccacSIjDlvCnP5WcCT6jXIAR30le8VA4FuT5F4PP0I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778064480; c=relaxed/simple; bh=UEqhS/gVtOtsoOlkx4tlcpnnBFw46fyozlsFkaRqtwY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DpqCIkIHjVDNgl7AmHx1QLgiW22FuVhB/7FCJNRSwjcmp90VKj5jJJqzG2OBxL4MkLmfYA4Cn9itcvanOaITr0E7pshBgGNNIQjp2XUcWmZdQNwoCUYjGrevdFD7oMomnQhs1QfeRSqw29+Mx1oyVwMocdkKS2Nl+Hp8N0ZzG0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BhtT+LYl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UVL4kfzz; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BhtT+LYl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UVL4kfzz" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6467H2JH248146 for ; Wed, 6 May 2026 10:47:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Fyr6BndDsbD/gd4UCCwHZ07yKpNDj6vKJfz1NBHwr0c=; b=BhtT+LYlUqoxEnkk xnpA6WhgB0YM/ZnqDxSWzhVy7F+iwRRTL7Y1I8kiBpFeQvq0rcvrQE2RKoDzvr2k Fx23YlQlf4NNAurBFDTRS7xjbw6N5n0B+tE3qeedn7Axqx2lYY6ODwiyWBYT/xkx FEpgcbPDmxMFqnlQ6z6eRLXx9fjAa5+gmnQ5NEkDfKijEvvuBjykSsqPQKjq6hv0 S9MTxCqVQMuuLfbaGFsP+fvlf9Kf/qb0UXMV5UgoiIsD68seEKTWuaBzH5fxOSi1 KBIpAUeL26ty1ek03jpIL8J8eU1NKahhis3OwaBK61vZYctRWx1B/3qVlCrm7bJu mxiNaw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dyjq44405-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 06 May 2026 10:47:58 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8d59968444aso142186585a.3 for ; Wed, 06 May 2026 03:47:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778064477; x=1778669277; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Fyr6BndDsbD/gd4UCCwHZ07yKpNDj6vKJfz1NBHwr0c=; b=UVL4kfzzba/HZxvCMcFTg+w2EycNyu4+ULfQeMFznMyNr/YdjVoW/BrkKdNM9O0mmW T/nq02IZX0P0OtLwS3OdI3FpuzWW7aQc+lknk7UZ51Z+6kMugqcEPgHxg+mCq2yeTWJ8 1HC6NvO+yhtT8aAWcLaPEouTpCn0dGZNTiQ1BrR+QAv28RQZ4I5Dg4KnFBWbs8xPDwry dgQrev0hU+9zH34er5v/hTf6F22MOUTZDh6L2r+lNQPqhu5Vv3vypMXewnuZzv6tPlO1 Lbl1jjtm5UWCRV8wiMWboldIwSdXJemOOwn3Bio17ywNwqXNvGeulMsOdnB30DZyyR/e sVGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778064477; x=1778669277; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Fyr6BndDsbD/gd4UCCwHZ07yKpNDj6vKJfz1NBHwr0c=; b=rpwWm/iP+DRBG7NpmK3C+bVpA/Cj9osFgSSSGCwZtNWPGIcGXv18RyT7ILiW2+6Zvw AtfUl6OXT4WfU5ebPxRrMPIvSQH81FBO8yb0uA6mdy36U99kOrhKc9KDLbwDNfk+OOxN pBuY1uW5J7LVSrtwaY+gBDOMBeBtfRf/spd/8cWgYmhtKVT2YlywU1EhSUSa8NIDrHet wrBs5h8T7kMTy23XdlzDiGkxwl1VCHnXmgTe/kixj1veSR4Gz311/hZnz84k+WebEOyJ 00z6d7pIJq3ccjPgHAqdP+twCROdanGVPpXVhBAH+67yuUVzwynHa8TbLKDIGxOB0JFG izAQ== X-Forwarded-Encrypted: i=1; AFNElJ9DJ+pVF8nhhmV/m3tt3w+s2yew05l3tSlaW8HlxD+tAviFbJgJAavb62A++DRjn/aMBQqTiAYa08tYWz4=@vger.kernel.org X-Gm-Message-State: AOJu0YxMVcZ71E7LUXUprY4oZL/nSKZaIehfjk3N5e7mQMh5kSTvL7l1 iCd+iFcYmQgNNOgkOsU3A761HBjvZeXzZ7r4RzTw70Ypinc2tzfQVGx1/hGFo3rJy3RlM6KZ8YF jRVKOR2vZzP/NU5tT2nU8Zvx1pe414QxBFXQ4yzTaslCzIBFaXGAZ9R4em/092c8i7kM= X-Gm-Gg: AeBDieu8uFZZnP/uSRupR7wGuSHMeCwGFtLaJqj1YXDcNELuVH0BTNLNOBsjx9jySBI aj325lOSJpNZ9E51MxbU5sPP2tEKAkCk3/GmmmoIVG4G9xHIgk/KGtDURSTZ4H6ydHwC4J2rBfT r0zpZPV5AU4Lgk9XX8BsWjctnlGcoNaWzV2AiWcBZUfADaO8hACDnS50sRls0l/UPrdwuIkFEwd n0W/kdz1HE43o2F3mxNsUYrA0reSUBgwupOv0HFjpcvto+i3yI0ZkfPlDWU2zys52x01+i9bpvK rao9oROUpL+pHpGkyy5sMML/P0UTuE1VhiJapCT3f8+938Yg6Dbr4QE6DOe+s9Lq6LBgB0avPwq 8xQOt3Q7jBS0DzJDWQOuJc/0+HerEzj78+DcpfKffBiRE8Ym60ih/6dHTd7OXKl0BnYsulRGIzY OxdwzSlQDzGCnpbQ== X-Received: by 2002:a05:620a:472a:b0:8f1:9e59:2208 with SMTP id af79cd13be357-9051daff561mr168915685a.4.1778064477610; Wed, 06 May 2026 03:47:57 -0700 (PDT) X-Received: by 2002:a05:620a:472a:b0:8f1:9e59:2208 with SMTP id af79cd13be357-9051daff561mr168913385a.4.1778064477181; Wed, 06 May 2026 03:47:57 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-67cd91a486csm1116640a12.17.2026.05.06.03.47.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 03:47:55 -0700 (PDT) Message-ID: <486d6b30-8762-4f14-aa19-7c5497cba00f@oss.qualcomm.com> Date: Wed, 6 May 2026 12:47:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: cache: qcom,llcc: Document Eliza LLCC block To: Krzysztof Kozlowski , Abel Vesa Cc: Bjorn Andersson , Konrad Dybcio , Conor Dooley , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260504-eliza-llcc-v1-0-d7006c899812@oss.qualcomm.com> <20260504-eliza-llcc-v1-1-d7006c899812@oss.qualcomm.com> <20260506-imported-emerald-quoll-fd1ef8@quoll> <0028dd41-d039-4ef5-a9f7-deb730a05b0b@oss.qualcomm.com> <319fc5ac-1211-4845-9a66-79f1a3026126@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <319fc5ac-1211-4845-9a66-79f1a3026126@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=MYxcfZ/f c=1 sm=1 tr=0 ts=69fb1c5e cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=u3ptBUEvLvOtx8rFk0cA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA2MDEwNCBTYWx0ZWRfX/0sVCdG8amc+ KBN5p1Rnnn7tKxJSXhUk5hyj6iaLM8/fYwkLLUkdGdqIcx14InOFUE87owVjCOge8GWfWlXRjHv MoJ/kh+RK/Tiee47jH9kyH119ah4cjxa2REzw1PZZZ2cSaTmXuNyNb2taoZpgij0PNdkjoff1DU hCrJ2sdm6JrB+qBGGDjo8w4w/13pymYe5pYET+r/OyXf9m4y1sG1i9tUBELpWInLnQi0yHaW6fe 3l9VJmM6hDrfAuK3p3RU4c/xk7DQ56Au0TR2CRB9pw0knSiwcwEdyyk5YqrhN62rEBxy0hpwD1a ho81cYs7r4wJ5GFcP8FSfMMAXRbbRZDrg75P1eg26JnWngMLMgStJpMUzDgwgN+SzAjldHLdiAK TdKyqRBNkdMDgk7wGMEiGeQYfxHOyTLUNIZLoLvn9hhUb4yFFBZtBRmnNtHcxX7+N/oJyhAh34g hlaVaJsEVSpK9spSG3A== X-Proofpoint-GUID: hGzsFAbVXv40HUGPTh-hHRvMFm0AIq0n X-Proofpoint-ORIG-GUID: hGzsFAbVXv40HUGPTh-hHRvMFm0AIq0n X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-05_03,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 phishscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605060104 On 5/6/26 11:56 AM, Krzysztof Kozlowski wrote: > On 06/05/2026 10:49, Konrad Dybcio wrote: >> On 5/6/26 10:25 AM, Krzysztof Kozlowski wrote: >>> On Mon, May 04, 2026 at 01:00:07PM +0300, Abel Vesa wrote: >>>> Document the Last Level Cache Controller on Eliza SoC. Eliza LLCC has 2 >>>> base register regions and an additional AND, OR broadcast region, total 4 >>>> register regions. >>>> >>>> Signed-off-by: Abel Vesa >>>> --- >>>> .../devicetree/bindings/cache/qcom,llcc.yaml | 22 ++++++++++++++++++++++ >>>> 1 file changed, 22 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml >>>> index 995d57815781..90f5a54b76e3 100644 >>>> --- a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml >>>> +++ b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml >>>> @@ -20,6 +20,7 @@ description: | >>>> properties: >>>> compatible: >>>> enum: >>>> + - qcom,eliza-llcc >>>> - qcom,glymur-llcc >>>> - qcom,ipq5424-llcc >>>> - qcom,kaanapali-llcc >>>> @@ -341,6 +342,27 @@ allOf: >>>> - const: llcc_broadcast_base >>>> - const: llcc_broadcast_and_base >>>> >>>> + - if: >>>> + properties: >>>> + compatible: >>>> + contains: >>>> + enum: >>>> + - qcom,eliza-llcc >>>> + then: >>>> + properties: >>>> + reg: >>>> + items: >>>> + - description: LLCC0 base register region >>>> + - description: LLCC2 base register region >>> >>> LLCC1? >> >> Unfortunately not > > Then let's just skip the names, because it will cause unnecessary > confusion when name is llcc1 (since it is the NEXT entry) but it points > to block called LLCC2 in the manual. I don't think skipping the names is a good idea, especially since if we keep them, we could teach the driver what channel the region actually corresponds to Konrad