From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Thadeu Lima de Souza Cascardo <cascardo@minaslivre.org>
Cc: linux-kernel@vger.kernel.org, sfr@canb.auug.org.au, rjw@sisk.pl,
"Randy.Dunlap" <rdunlap@xenotime.net>
Subject: Re: [PATCH] xen: new power management driver calls
Date: Tue, 08 Jul 2008 13:18:10 -0700 [thread overview]
Message-ID: <4873CB82.70002@goop.org> (raw)
In-Reply-To: <20080708201327.GA11888@vespa.holoscopio.com>
Thadeu Lima de Souza Cascardo wrote:
> linux-next won't build with CONFIG_XEN and CONFIG_PM_SLEEP because
> xen_suspend calls device_power_up and device_resume, which require a
> parameter since commit 1eede070a59e1cc73da51e1aaa00d9ab86572cfc.
>
Someone (Randy?) reported this before, but then I quietly forgot all
about it. Thanks for the patch.
Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
J
> ---
> drivers/xen/manage.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
> index 5b546e3..64c554e 100644
> --- a/drivers/xen/manage.c
> +++ b/drivers/xen/manage.c
> @@ -63,7 +63,7 @@ static int xen_suspend(void *data)
> gnttab_resume();
> xen_mm_unpin_all();
>
> - device_power_up();
> + device_power_up(PMSG_RESUME);
>
> if (!*cancelled) {
> xen_irq_resume();
> @@ -112,7 +112,7 @@ static void do_suspend(void)
> else
> xenbus_suspend_cancel();
>
> - device_resume();
> + device_resume(PMSG_RESUME);
>
> /* Make sure timer events get retriggered on all CPUs */
> clock_was_set();
>
next prev parent reply other threads:[~2008-07-08 20:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 20:13 Thadeu Lima de Souza Cascardo
2008-07-08 20:18 ` Jeremy Fitzhardinge [this message]
2008-07-08 22:48 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4873CB82.70002@goop.org \
--to=jeremy@goop.org \
--cc=cascardo@minaslivre.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=rjw@sisk.pl \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®