From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EF0BC001B0 for ; Tue, 8 Aug 2023 19:23:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236167AbjHHTXi (ORCPT ); Tue, 8 Aug 2023 15:23:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236065AbjHHTWl (ORCPT ); Tue, 8 Aug 2023 15:22:41 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C92D4112450; Tue, 8 Aug 2023 09:46:56 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id C629A5C00A8; Tue, 8 Aug 2023 04:02:50 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Tue, 08 Aug 2023 04:02:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1691481770; x=1691568170; bh=Sp DaR7i7R4jir2nSPb/IHojOH5Ejtlxz8VTxnsIiQQk=; b=u1WnBMVQOTf7j2DlqH /nYYDrjfRUTMffWJ8BIV7YS24zwiW9W0RRF3o3CL4JKi2qGC8rvLgRvMRd9/fHzF uYd2g9YO1XEnHdE2xeCbytYU0FMD6ubMau7/vUPlZZv4Oa1Hja81+lFmfG8a+pfc pOqL4ZBI/0+Uv6M+JyC0OViuEcP8GD1x+S+qm4jZDdE58CUw4FTxl27AtFn1HwxP 2jxIDy54npwmdEnmzo6GPH8RwKcRUZKr3dKq+N5vsNP5Ljuw1SY96wjCCqkbIR+B 9DtOGa5deMfh1drSGYrFh0//dR+6TSQHpqi3DYH4uupn1ejCZCB6jR9H9PNX5Xne GyYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1691481770; x=1691568170; bh=SpDaR7i7R4jir 2nSPb/IHojOH5Ejtlxz8VTxnsIiQQk=; b=zWLIdpSZsxtisBULh8uXVlRFlu6qp XXrfhIYdOxptbOZWeZ7AyNSw9jHHPqXxaWnRfp69spGesEh1f+VPfyu1Gu+K+e0x bx4dEm6RLNxRxgAMQmnKcXkcilesOhgr2GrTGPXoPE50cacPXjgo2sJ7anCsPO5V qqONvsaKfA6SeFQecwJMY3bO0wJmliqH46TYlVDcxWZyIcI8RJnbSSc5KRPlOqkP jplqfzih/6UAwsWXM2KhnkCVKsVlUJmIL1qAaj1uPlimIxGVE7P/4kn55LI5vIO1 tJ/qt8hRtYi3YvhKRKkeGhWpu8P5P9huq/T5aXCnPE5DgrtGvU9DJVpeg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrledvucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh epofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehrnhguuceu vghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrthhtvghrnh epffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdekteffnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnhguse grrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 1DCE8B60089; Tue, 8 Aug 2023 04:02:49 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-624-g7714e4406d-fm-20230801.001-g7714e440 Mime-Version: 1.0 Message-Id: <487477f3-9708-4a28-a4fa-0c652353467b@app.fastmail.com> In-Reply-To: <20230808072501.3393-1-Wenhua.Lin@unisoc.com> References: <20230808072501.3393-1-Wenhua.Lin@unisoc.com> Date: Tue, 08 Aug 2023 10:02:28 +0200 From: "Arnd Bergmann" To: "Wenhua Lin" , "Dmitry Torokhov" , "Jonathan Cameron" , "Andy Shevchenko" , =?UTF-8?Q?Nuno_S=C3=A1?= , "Samuel Holland" , "Robert Jarzmik" , "Mattijs Korpershoek" , "Bartosz Golaszewski" , "Orson Zhai" , "Baolin Wang" , "Chunyan Zhang" Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "wenhua lin" , "Xiongpeng Wu" Subject: Re: [PATCH] input: keyboard: Add sprd-keypad driver Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 8, 2023, at 09:25, Wenhua Lin wrote: > Add matrix keypad driver, support matrix keypad function. > > Signed-off-by: Wenhua Lin Looks fine to me, just one minor thing to remember: > +static int __maybe_unused sprd_keypad_resume(struct device *dev) > +{ > + struct sprd_keypad_data *data = dev_get_drvdata(dev); > + int ret = 0; > + > + if (!device_may_wakeup(dev)) { > + ret = sprd_keypad_enable(data); > + if (ret) > + return ret; > + ret = sprd_keypad_hw_init(data); > + } > + > + return ret; > +} > + > +static SIMPLE_DEV_PM_OPS(sprd_keypad_pm_ops, > + sprd_keypad_suspend, sprd_keypad_resume); > + SIMPLE_DEV_PM_OPS() is deprecated, please use the new DEFINE_SIMPLE_DEV_PM_OPS() for all new drivers, and remove the __maybe_unused annotation that is no longer needed with that. With that addressed (for the driver in general, I know nothing about the drivers/input specifics) Acked-by: Arnd Bergmann Arnd